Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: tests/Time.cpp

Issue 711143002: tests/Time.cpp: more verbose errors (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkTime.h" 8 #include "SkTime.h"
9 #include "Test.h" 9 #include "Test.h"
10 10
11 // Sanity checks for the GetDateTime function. 11 // Sanity checks for the GetDateTime function.
12 DEF_TEST(Time_GetDateTime, r) { 12 DEF_TEST(Time_GetDateTime, r) {
13 SkTime::DateTime dateTime; 13 SkTime::DateTime dateTime;
14 SkTime::GetDateTime(&dateTime); 14 SkTime::GetDateTime(&dateTime);
15 15
16 // TODO(future generation): update these values. 16 // TODO(future generation): update these values.
17 const uint16_t kMinimumSaneYear = 2014; 17 const uint16_t kMinimumSaneYear = 1964;
18 const uint16_t kMaximumSaneYear = 2064; 18 const uint16_t kMaximumSaneYear = 2064;
19 REPORTER_ASSERT(r, dateTime.fYear >= kMinimumSaneYear); 19
20 REPORTER_ASSERT(r, dateTime.fYear <= kMaximumSaneYear); 20 if (dateTime.fYear < kMinimumSaneYear) {
21 ERRORF(r,
22 "SkTime::GetDateTime: %u (CurrentYear) < %u (MinimumSaneYear)",
23 static_cast<unsigned>(dateTime.fYear),
24 static_cast<unsigned>(kMinimumSaneYear));
25 }
26 if (dateTime.fYear > kMaximumSaneYear) {
27 ERRORF(r,
28 "SkTime::GetDateTime: %u (CurrentYear) > %u (MaximumSaneYear)",
29 static_cast<unsigned>(dateTime.fYear),
30 static_cast<unsigned>(kMaximumSaneYear));
31 }
21 32
22 REPORTER_ASSERT(r, dateTime.fMonth >= 1); 33 REPORTER_ASSERT(r, dateTime.fMonth >= 1);
23 REPORTER_ASSERT(r, dateTime.fMonth <= 12); 34 REPORTER_ASSERT(r, dateTime.fMonth <= 12);
24 35
25 REPORTER_ASSERT(r, dateTime.fDay >= 1); 36 REPORTER_ASSERT(r, dateTime.fDay >= 1);
26 REPORTER_ASSERT(r, dateTime.fDay <= 31); 37 REPORTER_ASSERT(r, dateTime.fDay <= 31);
27 38
28 REPORTER_ASSERT(r, dateTime.fHour <= 23); 39 REPORTER_ASSERT(r, dateTime.fHour <= 23);
29 40
30 REPORTER_ASSERT(r, dateTime.fMinute <= 59); 41 REPORTER_ASSERT(r, dateTime.fMinute <= 59);
31 42
32 REPORTER_ASSERT(r, dateTime.fSecond <= 60); // leap seconds are 23:59:60 43 REPORTER_ASSERT(r, dateTime.fSecond <= 60); // leap seconds are 23:59:60
33 } 44 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698