SkDocument_PDF does somthing with the trimBox parameter.

SkDocument_PDF does somthing with the trimBox parameter.

Fixes change introduced in http://crrev.com/645563002

This will allow SkDocument to be a drop-in repalcement to
SkPDFDocument/SkPDFDevice in Chromium.

Committed: https://skia.googlesource.com/skia/+/93f816129356d6764a9402817cc36bffd8f991fb

[hal.canary, 2014-11-10 21:52:56]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-11-10 21:53:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/711133002/1

[commit-bot: I haz the power, 2014-11-10 21:53:09]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-11 03:53 UTC

[hal.canary, 2014-11-10 21:53:11]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2014-11-10 21:53:11]

PTAL

[reed1, 2014-11-10 22:01:38]

Assuming this is what trimbox means, lgtm

btw -- could be slightly more clear as

clipRect(trimbox)
translate(trimbox.x, y)

[commit-bot: I haz the power, 2014-11-10 22:02:01]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/93f816129356d6764a9402817cc36bffd8f991fb

[vandebo (ex-Chrome), 2014-11-11 15:44:53]

https://codereview.chromium.org/711133002/diff/1/src/doc/SkDocument_PDF.cpp
File src/doc/SkDocument_PDF.cpp (right):

https://codereview.chromium.org/711133002/diff/1/src/doc/SkDocument_PDF.cpp#n...
src/doc/SkDocument_PDF.cpp:48: fCanvas->clipRect(SkRect::MakeWH(trimBox.width(),
trimBox.height()));
Do headers and footers still work with this approach?

[hal.canary, 2014-11-11 16:15:53]

On 2014/11/11 15:44:53, vandebo (ex-Chrome) wrote:
> https://codereview.chromium.org/711133002/diff/1/src/doc/SkDocument_PDF.cpp
> File src/doc/SkDocument_PDF.cpp (right):
> 
>
https://codereview.chromium.org/711133002/diff/1/src/doc/SkDocument_PDF.cpp#n...
> src/doc/SkDocument_PDF.cpp:48:
fCanvas->clipRect(SkRect::MakeWH(trimBox.width(),
> trimBox.height()));
> Do headers and footers still work with this approach?

I tested this in Chrome.  They have been not using trimbox when they have
footers and headers.  This change is necessary to make SkDocument a drop in
replacement for SkPDFDocument.  See http://crrev.com//694213002 .