Issue 711113004: original

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 711113004: original (Closed)

Created:
6 years, 1 month ago by jam

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

original cl BUG=

Patch Set 1 #

Patch Set 2 : win compile fix #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+368 lines, -186 lines)			Patch
M	tools/gn/action_target_generator.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/build_settings.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	tools/gn/build_settings.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	tools/gn/command_format.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/filesystem_utils.h	View		2 chunks	+11 lines, -9 lines	0 comments	Download
M	tools/gn/filesystem_utils.cc	View		5 chunks	+56 lines, -31 lines	0 comments	Download
M	tools/gn/filesystem_utils_unittest.cc	View		3 chunks	+101 lines, -44 lines	0 comments	Download
M	tools/gn/function_exec_script.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/gn/function_get_path_info.cc	View		2 chunks	+18 lines, -9 lines	0 comments	Download
M	tools/gn/function_read_file.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/function_rebase_path.cc	View		4 chunks	+20 lines, -19 lines	0 comments	Download
M	tools/gn/function_rebase_path_unittest.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	tools/gn/function_write_file.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/functions.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/item.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/ninja_action_target_writer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/ninja_binary_target_writer.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	tools/gn/ninja_build_writer.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/ninja_target_writer.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	tools/gn/ninja_toolchain_writer.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/gn/output_file.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/gn/path_output.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/path_output.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	tools/gn/path_output_unittest.cc	View		8 chunks	+15 lines, -7 lines	0 comments	Download
M	tools/gn/setup.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/source_dir.cc	View	1	4 chunks	+30 lines, -0 lines	0 comments	Download
M	tools/gn/source_dir_unittest.cc	View		1 chunk	+39 lines, -17 lines	0 comments	Download
M	tools/gn/substitution_writer.cc	View		3 chunks	+5 lines, -7 lines	0 comments	Download
M	tools/gn/value_extractors.cc	View		2 chunks	+0 lines, -9 lines	0 comments	Download