Cleanup: Use BN_bn2bin_padded() for zero-padding rather than custom code.

Cleanup: Use BN_bn2bin_padded() for zero-padding rather than custom code.

Committed: https://crrev.com/0f4b2770055c29a698a0daaad87c57fe7f2169b5
Cr-Commit-Position: refs/heads/master@{#303535}

[eroman, 2014-11-10 22:12:39]

eroman@chromium.org changed reviewers:
+ davidben@chromium.org

[eroman, 2014-11-10 22:12:39]

(Came across this when searching for users of ECDSA)

[davidben, 2014-11-10 22:37:03]

lgtm (I'm so glad we added that function...)

https://codereview.chromium.org/711113003/diff/1/crypto/ec_signature_creator_...
File crypto/ec_signature_creator_openssl.cc (right):

https://codereview.chromium.org/711113003/diff/1/crypto/ec_signature_creator_...
crypto/ec_signature_creator_openssl.cc:65: const BIGNUM* r = ecdsa_sig.get()->r;
Nit: was there in the original, but doesn't ecdsa_sig->r work?

[eroman, 2014-11-10 22:42:02]

https://codereview.chromium.org/711113003/diff/1/crypto/ec_signature_creator_...
File crypto/ec_signature_creator_openssl.cc (right):

https://codereview.chromium.org/711113003/diff/1/crypto/ec_signature_creator_...
crypto/ec_signature_creator_openssl.cc:65: const BIGNUM* r = ecdsa_sig.get()->r;
On 2014/11/10 22:37:03, David Benjamin wrote:
> Nit: was there in the original, but doesn't ecdsa_sig->r work?

Done: I removed the variables and inlined as ecdsa_sig->r, ecdsa_sig->s

[eroman, 2014-11-10 22:42:42]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-11-10 22:43:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/711113003/20001

[commit-bot: I haz the power, 2014-11-10 23:43:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-10 23:44:39]

Patchset 2 (id:??) landed as
https://crrev.com/0f4b2770055c29a698a0daaad87c57fe7f2169b5
Cr-Commit-Position: refs/heads/master@{#303535}