Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 711073002: Revert of Suspect that this is causing crash, reverting.

Created:
6 years, 1 month ago by myuan
Modified:
6 years, 1 month ago
Reviewers:
matthewyuan
CC:
chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

Revert of Suspect that this is causing crash, reverting. (patchset #1 id:1 of https://codereview.chromium.org/708323002/) Reason for revert: Suspect cl is innocent. Original issue's description: > Suspect that this is causing crash, reverting. > > Revert "Disable notification views when clearing all notifications" > > This reverts commit e38e7b4b295e521e6bdbbacf50ab07fdea842d25. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/777ddc48181a23562af94c13e57fadebac33e75e TBR=matthewyuan@chromium.org NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M ui/message_center/views/message_center_view.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
myuan
Created Revert of Suspect that this is causing crash, reverting.
6 years, 1 month ago (2014-11-10 17:32:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711073002/1
6 years, 1 month ago (2014-11-10 17:33:38 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-10 17:33:41 UTC) #4
myuan
On 2014/11/10 17:33:41, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-11-10 22:17:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711073002/1
6 years, 1 month ago (2014-11-10 22:19:01 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 22:19:03 UTC) #9
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698