chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 711043002: Finch experiment for limiting the password bubble annoyance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 711043002: Finch experiment for limiting the password bubble annoyance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | chrome/browser/ui/passwords/password_bubble_experiment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index 039f58996025381f419552f17a426c65385bc35b..4afd3205d9c9fbdedc93ca8d61d96185b30a93a8 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/ui/chrome_pages.h"

#include "chrome/browser/ui/location_bar/location_bar.h"

#include "chrome/browser/ui/passwords/manage_passwords_icon.h"

+#include "chrome/browser/ui/passwords/password_bubble_experiment.h"

#include "chrome/common/url_constants.h"

#include "components/password_manager/core/browser/password_store.h"

#include "content/public/browser/notification_service.h"

@@ -268,6 +269,10 @@ void ManagePasswordsUIController::ShowBubbleWithoutUserInteraction() {

Browser* browser = chrome::FindBrowserWithWebContents(web_contents());

if (!browser || browser->toolbar_model()->input_in_progress())

return;

+ if (state_ == password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE &&

+ !password_bubble_experiment::ShouldShowBubble(

+ browser->profile()->GetPrefs()))

+ return;

CommandUpdater* updater = browser->command_controller()->command_updater();

updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE);

#endif