Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 711023002: Add remoting_host target to chromium_builder_webrtc dependencies (re-land) (Closed)

Created:
6 years, 1 month ago by kjellander_chromium
Modified:
6 years, 1 month ago
Reviewers:
perkj_chrome
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add remoting_host target to chromium_builder_webrtc dependencies (re-land) It turns out the remoting_host target should be in a condition to avoid failing building for some platforms. Previous https://codereview.chromium.org/706753003/ was reverted because of breaking Chrome OS Ozone. Committed: https://crrev.com/e766084c4096b33adf7aee03e3283b39e5e25e1a Cr-Commit-Position: refs/heads/master@{#304206}

Patch Set 1 #

Patch Set 2 : Include all remoting.gyp targets and add devtools_bridge targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/all.gyp View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kjellander_chromium
6 years, 1 month ago (2014-11-10 13:28:16 UTC) #2
perkj_chrome
lgtm Can we also add this project? They use the java lib. https://code.google.com/p/chromium/codesearch#chromium/src/components/devtools_bridge.gyp&q=PeerCOnnection.java&sq=package:chromium&l=16
6 years, 1 month ago (2014-11-10 14:47:39 UTC) #3
kjellander_chromium
On 2014/11/10 14:47:39, perkj wrote: > lgtm > > Can we also add this project? ...
6 years, 1 month ago (2014-11-14 09:49:23 UTC) #4
perkj_chrome
lgtm lgtm
6 years, 1 month ago (2014-11-14 13:04:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711023002/20001
6 years, 1 month ago (2014-11-14 13:04:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-14 14:02:16 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 14:03:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e766084c4096b33adf7aee03e3283b39e5e25e1a
Cr-Commit-Position: refs/heads/master@{#304206}

Powered by Google App Engine
This is Rietveld 408576698