Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 711003003: Map ROLE_SYSTEM_GROUPING to AX role for figure (Closed)

Created:
6 years, 1 month ago by je_julie(Not used)
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Map ROLE_SYSTEM_GROUPING to AX role for figure The spec says that ROLE_SYSTEM_GROUPING should be mapped for figure. http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#el-figure BUG=282035 Committed: https://crrev.com/4f2ae4ffd6d2485bc868f0b658c08f7cbb3d2e28 Cr-Commit-Position: refs/heads/master@{#303496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/data/accessibility/figcaption-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/figure-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
je_julie(Not used)
Hi Dominic, The spec was updated recently. http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#el-figure So, I updated code for figure role ...
6 years, 1 month ago (2014-11-10 14:52:03 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-10 17:09:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711003003/1
6 years, 1 month ago (2014-11-10 17:11:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 18:18:29 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 18:19:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f2ae4ffd6d2485bc868f0b658c08f7cbb3d2e28
Cr-Commit-Position: refs/heads/master@{#303496}

Powered by Google App Engine
This is Rietveld 408576698