Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 710903002: Revert of [GCM] Fetching OAuth2 tokens periodically in account tracker (Closed)

Created:
6 years, 1 month ago by matthewyuan
Modified:
6 years, 1 month ago
Reviewers:
kareng, Nicolas Zea, fgorski
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mapper-in-driver
Project:
chromium
Visibility:
Public.

Description

Revert of [GCM] Fetching OAuth2 tokens periodically in account tracker (patchset #7 id:140001 of https://codereview.chromium.org/631343002/) Reason for revert: Reverting since it's causing a crash on canary. Original issue's description: > [GCM] Fetching OAuth2 tokens periodically in account tracker > > BUG=374969 > R=zea@chromium.org > > Committed: https://crrev.com/ede4117a85d34a1c117169d538b297020e69de87 > Cr-Commit-Position: refs/heads/master@{#303340} TBR=zea@chromium.org,fgorski@chromium.org NOTREECHECKS=true NOTRY=true BUG=374969 Committed: https://crrev.com/74879efc7b4655dd1def63c53a5f73b46fb511d6 Cr-Commit-Position: refs/heads/master@{#303397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -203 lines) Patch
M chrome/browser/services/gcm/gcm_account_tracker.h View 4 chunks +2 lines, -26 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker.cc View 10 chunks +21 lines, -75 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker_unittest.cc View 8 chunks +3 lines, -87 lines 0 comments Download
M components/gcm_driver/gcm_client_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_client_impl.cc View 2 chunks +1 line, -6 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
matthewyuan
Created Revert of [GCM] Fetching OAuth2 tokens periodically in account tracker
6 years, 1 month ago (2014-11-08 22:29:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710903002/1
6 years, 1 month ago (2014-11-08 22:30:42 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-08 22:30:44 UTC) #4
kareng
On 2014/11/08 22:30:44, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-11-08 22:36:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710903002/1
6 years, 1 month ago (2014-11-08 22:36:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 22:37:13 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 22:38:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74879efc7b4655dd1def63c53a5f73b46fb511d6
Cr-Commit-Position: refs/heads/master@{#303397}

Powered by Google App Engine
This is Rietveld 408576698