Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 710873003: Move more methods from LocalDOMWindow to DOMWindow. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
haraken, Mike West
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Move more methods from LocalDOMWindow to DOMWindow. This is in preparation for changing Window.idl ImplementedAs to DOMWindow. These should be the remainder of the methods needed by V8 bindings. BUG=425623 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -82 lines) Patch
M Source/core/frame/DOMWindow.h View 3 chunks +82 lines, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 10 chunks +31 lines, -81 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
6 years, 1 month ago (2014-11-08 23:18:01 UTC) #2
Mike West
LGTM
6 years, 1 month ago (2014-11-09 12:00:31 UTC) #4
haraken
LGTM
6 years, 1 month ago (2014-11-09 14:47:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710873003/1
6 years, 1 month ago (2014-11-09 19:12:43 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-09 19:14:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185013

Powered by Google App Engine
This is Rietveld 408576698