Source/core/css/resolver/MatchedPropertiesCache.cpp - Issue 71083002: Web Animations: Use legacy cascade behaviour and the MatchedPropertiesCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 71083002: Web Animations: Use legacy cascade behaviour and the MatchedPropertiesCache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: address more comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/web-animations-css/animations/cascade-important-expected.txt ('k') | Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/MatchedPropertiesCache.cpp

diff --git a/Source/core/css/resolver/MatchedPropertiesCache.cpp b/Source/core/css/resolver/MatchedPropertiesCache.cpp

index 86c4c7345cb9a385e238a4abbea4f42fec215ed4..d3c222a1f1ebd376142c9127f55921f6945042c6 100644

--- a/Source/core/css/resolver/MatchedPropertiesCache.cpp

+++ b/Source/core/css/resolver/MatchedPropertiesCache.cpp

@@ -154,12 +154,6 @@ bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty

// The cache assumes static knowledge about which properties are inherited.

if (parentStyle->hasExplicitlyInheritedProperties())

return false;

- if (RuntimeEnabledFeatures::webAnimationsEnabled()) {

- if (style->transitions() && !style->transitions()->isEmpty())

- return false;

- if (style->animations() && !style->animations()->isEmpty())

- return false;

- }

return true;

}