LayoutTests/virtual/web-animations-css/animations/cascade-important-expected.txt - Issue 71083002: Web Animations: Use legacy cascade behaviour and the MatchedPropertiesCache

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/virtual/web-animations-css/animations/cascade-important-expected.txt

Issue 71083002: Web Animations: Use legacy cascade behaviour and the MatchedPropertiesCache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 PASS - "background-color" property for "test" element at 0s saw something close to: rgb(0, 128, 0)

2 PASS - "background-color" property for "test" element at 0.25s saw something clo se to: rgb(0, 128, 0)
esprehn 2013/11/13 07:37:43 Why are you deleting an expected result but not di Why are you deleting an expected result but not disabling any test or changing any tests? Timothy Loh 2013/11/13 23:12:14 I'm not sure what the standard thing to do here is Show quoted text On 2013/11/13 07:37:43, esprehn wrote: > Why are you deleting an expected result but not disabling any test or changing > any tests? I'm not sure what the standard thing to do here is; the test has an expected.txt in LayoutTests/animations with FAIL lines in it, which we will match after this change. Should I remove the test until we have the cascade working correctly? dstockwell 2013/11/13 23:19:50 No, keeping FAIL expectations is fine. 232273 will Show quoted text On 2013/11/13 23:12:14, Timothy Loh wrote: > On 2013/11/13 07:37:43, esprehn wrote: > > Why are you deleting an expected result but not disabling any test or changing > > any tests? > > I'm not sure what the standard thing to do here is; the test has an expected.txt > in LayoutTests/animations with FAIL lines in it, which we will match after this > change. Should I remove the test until we have the cascade working correctly? No, keeping FAIL expectations is fine. 232273 will track this.
3 PASS - "background-color" property for "test" element at 0.5s saw something clos e to: rgb(0, 128, 0)

4

OLD	NEW

« no previous file with comments | « no previous file | Source/core/css/resolver/MatchedPropertiesCache.cpp » ('j') | Source/core/css/resolver/StyleResolver.cpp » ('J')