Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/services/html_viewer/ax_provider_impl_unittest.cc

Issue 710803002: Beginning of an accessibility implementation for html_viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup, rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/services/html_viewer/ax_provider_impl.cc ('K') | « mojo/services/html_viewer/ax_provider_impl.cc ('k') | mojo/services/html_viewer/blink_platform_impl.h » ('j') | mojo/services/html_viewer/html_document_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/html_viewer/ax_provider_impl_unittest.cc
diff --git a/mojo/services/html_viewer/ax_provider_impl_unittest.cc b/mojo/services/html_viewer/ax_provider_impl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5f497e570369d59b42b28d0f477023c339b28d74
--- /dev/null
+++ b/mojo/services/html_viewer/ax_provider_impl_unittest.cc
@@ -0,0 +1,173 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/services/html_viewer/ax_provider_impl.h"
+
+#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
+#include "base/metrics/stats_counters.h"
+#include "mojo/services/html_viewer/blink_platform_impl.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/platform/WebData.h"
+#include "third_party/WebKit/public/platform/WebURL.h"
+#include "third_party/WebKit/public/web/WebFrameClient.h"
+#include "third_party/WebKit/public/web/WebKit.h"
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "third_party/WebKit/public/web/WebView.h"
+#include "third_party/WebKit/public/web/WebViewClient.h"
+#include "url/gurl.h"
+
+using blink::WebData;
+using blink::WebLocalFrame;
+using blink::WebFrameClient;
+using blink::WebURL;
+using blink::WebView;
+using blink::WebViewClient;
+
+namespace mojo {
+
+namespace {
+
+class TestWebFrameClient : public WebFrameClient {
+ public:
+ virtual ~TestWebFrameClient() {}
+ virtual void didStopLoading() { base::MessageLoop::current()->Quit(); }
+};
+
+class TestWebViewClient : public WebViewClient {
+ public:
+ virtual bool allowsBrokenNullLayerTreeView() const { return true; }
+ virtual ~TestWebViewClient() {}
+};
+
+class AxProviderImplTest : public testing::Test {
+ public:
+ AxProviderImplTest() { blink::initialize(new BlinkPlatformImpl()); }
+
+ virtual ~AxProviderImplTest() override { blink::shutdown(); }
+
+ private:
+ base::MessageLoopForUI message_loop;
+};
+
+struct NodeCatcher {
abarth-chromium 2014/11/10 00:33:04 Cute
+ void OnNodes(Array<AxNodePtr> nodes) { this->nodes = nodes.Pass(); }
+ Array<AxNodePtr> nodes;
+};
+
+AxNodePtr CreateNode(int id,
+ int parent_id,
+ int next_sibling_id,
+ const RectPtr& bounds,
+ const std::string& url,
+ const std::string& text) {
+ AxNodePtr node(AxNode::New());
+ node->id = id;
+ node->parent_id = parent_id;
+ node->next_sibling_id = next_sibling_id;
+ node->bounds = bounds.Clone();
+
+ if (!url.empty()) {
+ node->link = AxLink::New();
+ node->link->url = url;
+ }
+ if (!text.empty()) {
+ node->text = AxText::New();
+ node->text->content = text;
+ }
+ return node.Pass();
+}
+
+} // namespace
+
+TEST_F(AxProviderImplTest, Basic) {
+ TestWebViewClient web_view_client;
+ TestWebFrameClient web_frame_client;
+ WebView* view = WebView::create(&web_view_client);
+ view->setMainFrame(WebLocalFrame::create(&web_frame_client));
+ view->mainFrame()->loadHTMLString(
+ WebData(
+ "<html><body>foo<a "
+ "href='http://monkey.net'>bar</a>baz</body></html>"),
+ WebURL(GURL("http://someplace.net")));
+
+ AxProviderImpl ax_provider_impl(view);
+ NodeCatcher catcher;
+ base::MessageLoop::current()->Run();
abarth-chromium 2014/11/10 00:33:04 I'd probably move this to just below loadHTMLStrin
Aaron Boodman 2014/11/10 07:05:53 Done.
+ ax_provider_impl.GetTree(
+ base::Bind(&NodeCatcher::OnNodes, base::Unretained(&catcher)));
+
+ std::map<uint32, AxNode*> lookup;
+ for (size_t i = 0; i < catcher.nodes.size(); ++i) {
+ auto& node = catcher.nodes[i];
abarth-chromium 2014/11/10 00:33:04 We can't use for (auto& node : catcher.nodes) ? M
Aaron Boodman 2014/11/10 07:05:53 agree.
+ lookup[node->id] = node.get();
+ }
+
+ typedef decltype(lookup)::value_type MapEntry;
+ auto is_link = [](MapEntry pair) { return pair.second->link.get(); };
+ auto is_text = [](MapEntry pair, const char* content) {
+ return pair.second->text.get() &&
+ pair.second->text->content.To<std::string>() == content;
+ };
+ auto is_foo = [&is_text](MapEntry pair) { return is_text(pair, "foo"); };
+ auto is_bar = [&is_text](MapEntry pair) { return is_text(pair, "bar"); };
+ auto is_baz = [&is_text](MapEntry pair) { return is_text(pair, "baz"); };
abarth-chromium 2014/11/10 00:33:04 Mind blown!
abarth-chromium 2014/11/10 00:33:04 Mind blown!
Aaron Boodman 2014/11/10 07:05:53 Too bad we can't use stl 11. Could do this with st
+
+ EXPECT_EQ(1u, std::count_if(lookup.begin(), lookup.end(), is_link));
+ EXPECT_EQ(1u, std::count_if(lookup.begin(), lookup.end(), is_foo));
+ EXPECT_EQ(1u, std::count_if(lookup.begin(), lookup.end(), is_bar));
+ EXPECT_EQ(1u, std::count_if(lookup.begin(), lookup.end(), is_baz));
+
+ auto root = lookup[1u];
+ auto link = std::find_if(lookup.begin(), lookup.end(), is_link)->second;
+ auto foo = std::find_if(lookup.begin(), lookup.end(), is_foo)->second;
+ auto bar = std::find_if(lookup.begin(), lookup.end(), is_bar)->second;
+ auto baz = std::find_if(lookup.begin(), lookup.end(), is_baz)->second;
+
+ // Test basic content of each node. The properties we copy (like parent_id)
+ // here are tested differently below.
+ EXPECT_TRUE(CreateNode(root->id, 0, 0, root->bounds, "", "")->Equals(*root));
+ EXPECT_TRUE(CreateNode(foo->id, foo->parent_id, 0, foo->bounds, "", "foo")
+ ->Equals(*foo));
+ EXPECT_TRUE(CreateNode(bar->id, bar->parent_id, 0, bar->bounds, "", "bar")
+ ->Equals(*bar));
+ EXPECT_TRUE(CreateNode(baz->id, baz->parent_id, 0, baz->bounds, "", "baz")
+ ->Equals(*baz));
+ EXPECT_TRUE(CreateNode(link->id,
+ link->parent_id,
+ link->next_sibling_id,
+ link->bounds,
+ "http://monkey.net/",
+ "")->Equals(*link));
+
+ auto is_descendant_of = [&lookup](uint32 id, uint32 ancestor) {
+ for (; (id = lookup[id]->parent_id) != 0;) {
+ if (id == ancestor)
+ return true;
+ }
+ return false;
+ };
+
+ EXPECT_TRUE(is_descendant_of(bar->id, link->id));
+ for (auto pair : lookup) {
+ AxNode* node = pair.second;
+ if (node != root)
+ EXPECT_TRUE(is_descendant_of(node->id, 1u));
+ if (node != link && node != foo && node != bar && node != baz) {
+ EXPECT_TRUE(CreateNode(node->id,
+ node->parent_id,
+ node->next_sibling_id,
+ node->bounds,
+ "",
+ ""));
+ }
+ }
+
+ // TODO(aa): Test bounds.
+ // TODO(aa): Test sibling ordering of foo/bar/baz.
+
+ view->close();
+}
+
+} // namespace mojo
« mojo/services/html_viewer/ax_provider_impl.cc ('K') | « mojo/services/html_viewer/ax_provider_impl.cc ('k') | mojo/services/html_viewer/blink_platform_impl.h » ('j') | mojo/services/html_viewer/html_document_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698