Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1963)

Unified Diff: mojo/services/html_viewer/html_document_view.h

Issue 710803002: Beginning of an accessibility implementation for html_viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/html_viewer/blink_platform_impl.cc ('k') | mojo/services/html_viewer/html_document_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/html_viewer/html_document_view.h
diff --git a/mojo/services/html_viewer/html_document_view.h b/mojo/services/html_viewer/html_document_view.h
index 68314854b098367548af6ac27304106fe90791aa..d1cd1eb5c116b3c9c271a3fabbcdc0fefc517b3e 100644
--- a/mojo/services/html_viewer/html_document_view.h
+++ b/mojo/services/html_viewer/html_document_view.h
@@ -5,12 +5,15 @@
#ifndef MOJO_SERVICES_HTML_VIEWER_HTML_DOCUMENT_VIEW_H_
#define MOJO_SERVICES_HTML_VIEWER_HTML_DOCUMENT_VIEW_H_
+#include <set>
+
#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
+#include "mojo/public/cpp/application/interface_factory.h"
#include "mojo/public/cpp/application/lazy_interface_ptr.h"
#include "mojo/public/cpp/application/service_provider_impl.h"
#include "mojo/public/cpp/bindings/interface_impl.h"
#include "mojo/public/interfaces/application/application.mojom.h"
+#include "mojo/services/html_viewer/ax_provider_impl.h"
#include "mojo/services/public/cpp/view_manager/view_manager_client_factory.h"
#include "mojo/services/public/cpp/view_manager/view_manager_delegate.h"
#include "mojo/services/public/cpp/view_manager/view_observer.h"
@@ -26,6 +29,7 @@ class MessageLoopProxy;
namespace mojo {
+class AxProviderImpl;
class WebMediaPlayerFactory;
class ViewManager;
class View;
@@ -36,7 +40,8 @@ class HTMLDocumentView : public mojo::InterfaceImpl<mojo::Application>,
public blink::WebViewClient,
public blink::WebFrameClient,
public ViewManagerDelegate,
- public ViewObserver {
+ public ViewObserver,
+ public InterfaceFactory<AxProvider> {
public:
// Load a new HTMLDocument with |response|.
//
@@ -107,6 +112,10 @@ class HTMLDocumentView : public mojo::InterfaceImpl<mojo::Application>,
void OnViewDestroyed(View* view) override;
void OnViewInputEvent(View* view, const EventPtr& event) override;
+ // InterfaceFactory<AxProvider>
+ void Create(ApplicationConnection* connection,
+ InterfaceRequest<AxProvider> request) override;
+
void Load(URLResponsePtr response);
URLResponsePtr response_;
@@ -121,7 +130,9 @@ class HTMLDocumentView : public mojo::InterfaceImpl<mojo::Application>,
scoped_refptr<base::MessageLoopProxy> compositor_thread_;
WebMediaPlayerFactory* web_media_player_factory_;
- base::WeakPtrFactory<HTMLDocumentView> weak_factory_;
+ // HTMLDocumentView owns these pointers.
+ std::set<AxProviderImpl*> ax_provider_impls_;
+
DISALLOW_COPY_AND_ASSIGN(HTMLDocumentView);
};
« no previous file with comments | « mojo/services/html_viewer/blink_platform_impl.cc ('k') | mojo/services/html_viewer/html_document_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698