Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 7108020: Add automatic retry mechanism and LKGR support. (Closed)

Created:
9 years, 6 months ago by M-A Ruel
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Add automatic retry mechanism and LKGR support. Add code to determine good revision per builder and fallback to LKGR when all hope is lost. This required rewriting StepDb (yet) again. The retry mechanism special cases update and compile steps. Remove thirdparty since SortedDict is not necessary anymore. R=dpranke@chromium.org BUG= TEST=Lots ABANDONNED

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -707 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M projects.py View 3 chunks +10 lines, -1 line 0 comments Download
M tests/try_server_test.py View 11 chunks +202 lines, -51 lines 1 comment Download
D thirdparty/README.chromium View 1 chunk +0 lines, -6 lines 0 comments Download
D thirdparty/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D thirdparty/datastructures.py View 1 chunk +0 lines, -505 lines 0 comments Download
M verification/try_server.py View 10 chunks +126 lines, -144 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
I haven't live tested yet, I've focused on writing unit tests instead.
9 years, 6 months ago (2011-06-08 13:40:54 UTC) #1
Dirk Pranke
A couple of nits, but frankly I've lost the bigger picture. What was the logic ...
9 years, 6 months ago (2011-06-08 22:49:49 UTC) #2
Dirk Pranke
LGTM once you address the nits (one way or another). I'll take the "bigger picture" ...
9 years, 6 months ago (2011-06-08 23:51:00 UTC) #3
M-A Ruel
9 years, 6 months ago (2011-06-09 16:10:20 UTC) #4
There is an issue with this change, since update_status() doesn't have the patch
applied, the job was sent without a patch. I'll split it in parts, closing in
the meantime.

Powered by Google App Engine
This is Rietveld 408576698