net/spdy/spdy_headers_block_parser_test.cc - Issue 710713002: Remove SPDY2 and SPDY/3.0 from tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_headers_block_parser_test.cc

Issue 710713002: Remove SPDY2 and SPDY/3.0 from tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_headers_block_parser_test.cc

diff --git a/net/spdy/spdy_headers_block_parser_test.cc b/net/spdy/spdy_headers_block_parser_test.cc

index dc2cbb5daecd20e38b178aa537017cb5a9135bb6..31d5f296457c72e8f82da19f4b5b672e910460b2 100644

--- a/net/spdy/spdy_headers_block_parser_test.cc

+++ b/net/spdy/spdy_headers_block_parser_test.cc

@@ -109,10 +109,9 @@ class SpdyHeadersBlockParserTest :

const char *const SpdyHeadersBlockParserTest::kBaseKey = "test_key";

const char *const SpdyHeadersBlockParserTest::kBaseValue = "test_value";

-// All tests are run with 3 different SPDY versions: SPDY/2, SPDY/3, SPDY/4.

INSTANTIATE_TEST_CASE_P(SpdyHeadersBlockParserTests,

SpdyHeadersBlockParserTest,

- ::testing::Values(SPDY2, SPDY3, SPDY4));

+ ::testing::Values(SPDY3, SPDY4));

TEST_P(SpdyHeadersBlockParserTest, BasicTest) {

// Sanity test, verify that we parse out correctly a block with