Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2693)

Unified Diff: net/spdy/spdy_stream_unittest.cc

Issue 710713002: Remove SPDY2 and SPDY/3.0 from tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_stream_unittest.cc
diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc
index a6926ab6936e275b187efb36000ea6b4e18b1868..fee4c285067322ae076e5c51b014e66e8dd6e8fe 100644
--- a/net/spdy/spdy_stream_unittest.cc
+++ b/net/spdy/spdy_stream_unittest.cc
@@ -110,8 +110,7 @@ class SpdyStreamTest : public ::testing::Test,
INSTANTIATE_TEST_CASE_P(
NextProto,
SpdyStreamTest,
- testing::Values(kProtoDeprecatedSPDY2,
- kProtoSPDY3, kProtoSPDY31, kProtoSPDY4));
+ testing::Values(kProtoSPDY31, kProtoSPDY4));
TEST_P(SpdyStreamTest, SendDataAfterOpen) {
GURL url(kStreamUrl);
@@ -717,9 +716,6 @@ TEST_P(SpdyStreamTest, DuplicateHeaders) {
// to overflow an int32. The SpdyStream should handle that case
// gracefully.
TEST_P(SpdyStreamTest, IncreaseSendWindowSizeOverflow) {
- if (spdy_util_.protocol() < kProtoSPDY3)
- return;
-
session_ =
SpdySessionDependencies::SpdyCreateSessionDeterministic(&session_deps_);
@@ -877,17 +873,11 @@ void SpdyStreamTest::RunResumeAfterUnstallRequestResponseTest(
}
TEST_P(SpdyStreamTest, ResumeAfterSendWindowSizeIncreaseRequestResponse) {
- if (spdy_util_.protocol() < kProtoSPDY3)
- return;
-
RunResumeAfterUnstallRequestResponseTest(
base::Bind(&IncreaseStreamSendWindowSize));
}
TEST_P(SpdyStreamTest, ResumeAfterSendWindowSizeAdjustRequestResponse) {
- if (spdy_util_.protocol() < kProtoSPDY3)
- return;
-
RunResumeAfterUnstallRequestResponseTest(
base::Bind(&AdjustStreamSendWindowSize));
}
@@ -972,17 +962,11 @@ void SpdyStreamTest::RunResumeAfterUnstallBidirectionalTest(
}
TEST_P(SpdyStreamTest, ResumeAfterSendWindowSizeIncreaseBidirectional) {
- if (spdy_util_.protocol() < kProtoSPDY3)
- return;
-
RunResumeAfterUnstallBidirectionalTest(
base::Bind(&IncreaseStreamSendWindowSize));
}
TEST_P(SpdyStreamTest, ResumeAfterSendWindowSizeAdjustBidirectional) {
- if (spdy_util_.protocol() < kProtoSPDY3)
- return;
-
RunResumeAfterUnstallBidirectionalTest(
base::Bind(&AdjustStreamSendWindowSize));
}

Powered by Google App Engine
This is Rietveld 408576698