net/spdy/spdy_frame_builder_test.cc - Issue 710713002: Remove SPDY2 and SPDY/3.0 from tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_frame_builder_test.cc

Issue 710713002: Remove SPDY2 and SPDY/3.0 from tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_frame_builder_test.cc

diff --git a/net/spdy/spdy_frame_builder_test.cc b/net/spdy/spdy_frame_builder_test.cc

index 38545586c98826f6f8880fc7c4e9e19f8f0d9592..50ddc966513ac31fc5b3291e0a4f9f0ed812a268 100644

--- a/net/spdy/spdy_frame_builder_test.cc

+++ b/net/spdy/spdy_frame_builder_test.cc

@@ -18,10 +18,9 @@ class SpdyFrameBuilderTest : public ::testing::TestWithParam<SpdyMajorVersion> {

SpdyMajorVersion spdy_version_;

};

-// All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.

INSTANTIATE_TEST_CASE_P(SpdyFrameBuilderTests,

SpdyFrameBuilderTest,

- ::testing::Values(SPDY2, SPDY3, SPDY4));

+ ::testing::Values(SPDY3, SPDY4));

TEST_P(SpdyFrameBuilderTest, GetWritableBuffer) {

const size_t builder_size = 10;