Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 7107005: Replace WPA and RSN with PSK in Other Wi-Fi network UI. (Closed)

Created:
9 years, 6 months ago by stevenjb
Modified:
9 years, 6 months ago
Reviewers:
James Cook, Charlie Lee
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Replace WPA and RSN with PSK in Other Wi-Fi network UI. BUG=chromium-os:13333 TEST=Network Menu > Other Wi-Fi Network > Security should have WEP and PSK. Both should still work. PSK should work for both RSN and WPA networks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87557

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unused strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -41 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
I spoke with Sam about the UI and we agreed that there is no need ...
9 years, 6 months ago (2011-06-01 22:45:33 UTC) #1
Charlie Lee
is it still ok to add new strings? http://codereview.chromium.org/7107005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7107005/diff/1/chrome/app/generated_resources.grd#newcode10583 chrome/app/generated_resources.grd:10583: <message ...
9 years, 6 months ago (2011-06-01 23:03:06 UTC) #2
James Cook
http://codereview.chromium.org/7107005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7107005/diff/1/chrome/app/generated_resources.grd#newcode10590 chrome/app/generated_resources.grd:10590: PSK (WPA or RSN) End-user documentation about Wi-Fi security ...
9 years, 6 months ago (2011-06-01 23:24:22 UTC) #3
stevenjb
I pinged Zel and he would rather push the change than wait. If we don't ...
9 years, 6 months ago (2011-06-01 23:34:37 UTC) #4
Charlie Lee
9 years, 6 months ago (2011-06-02 00:10:15 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698