Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: media/filters/chunk_demuxer.cc

Issue 710693003: Report PIPELINE_ERROR_DECODE when SourceState::Append fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: modify corresponding unit test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/filters/chunk_demuxer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.cc
diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc
index ffa7612299efb033612c3cb225f6198d3a2c4c6e..21579f16081bd6f15fe334f11d80134b032b2e06 100644
--- a/media/filters/chunk_demuxer.cc
+++ b/media/filters/chunk_demuxer.cc
@@ -1348,18 +1348,7 @@ void ChunkDemuxer::AppendData(
switch (state_) {
case INITIALIZING:
- DCHECK(IsValidId(id));
- if (!source_state_map_[id]->Append(data, length,
- append_window_start,
- append_window_end,
- timestamp_offset,
- init_segment_received_cb)) {
- ReportError_Locked(DEMUXER_ERROR_COULD_NOT_OPEN);
- return;
- }
- break;
-
- case INITIALIZED: {
+ case INITIALIZED:
DCHECK(IsValidId(id));
if (!source_state_map_[id]->Append(data, length,
append_window_start,
@@ -1369,7 +1358,7 @@ void ChunkDemuxer::AppendData(
ReportError_Locked(PIPELINE_ERROR_DECODE);
return;
}
- } break;
+ break;
case PARSE_ERROR:
DVLOG(1) << "AppendData(): Ignoring data after a parse error.";
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/filters/chunk_demuxer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698