Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 710663002: Adding role 'RubyRole' in blink to expose HTML Ruby tag. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 378
379 if (isHTMLOutputElement(node)) 379 if (isHTMLOutputElement(node))
380 return StatusRole; 380 return StatusRole;
381 381
382 if (isHTMLParagraphElement(node)) 382 if (isHTMLParagraphElement(node))
383 return ParagraphRole; 383 return ParagraphRole;
384 384
385 if (isHTMLLabelElement(node)) 385 if (isHTMLLabelElement(node))
386 return LabelRole; 386 return LabelRole;
387 387
388 if (isHTMLRubyElement(node))
389 return RubyRole;
390
388 if (isHTMLDivElement(node)) 391 if (isHTMLDivElement(node))
389 return DivRole; 392 return DivRole;
390 393
391 if (isHTMLMeterElement(node)) 394 if (isHTMLMeterElement(node))
392 return MeterRole; 395 return MeterRole;
393 396
394 if (isHTMLFormElement(node)) 397 if (isHTMLFormElement(node))
395 return FormRole; 398 return FormRole;
396 399
397 if (node && node->hasTagName(articleTag)) 400 if (node && node->hasTagName(articleTag))
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 730
728 if (roleValue() == FigureRole) 731 if (roleValue() == FigureRole)
729 return false; 732 return false;
730 733
731 if (roleValue() == DetailsRole) 734 if (roleValue() == DetailsRole)
732 return false; 735 return false;
733 736
734 if (roleValue() == MeterRole) 737 if (roleValue() == MeterRole)
735 return false; 738 return false;
736 739
740 if (roleValue() == RubyRole)
741 return false;
742
737 // if this element has aria attributes on it, it should not be ignored. 743 // if this element has aria attributes on it, it should not be ignored.
738 if (supportsARIAAttributes()) 744 if (supportsARIAAttributes())
739 return false; 745 return false;
740 746
741 // <span> tags are inline tags and not meant to convey information if they h ave no other aria 747 // <span> tags are inline tags and not meant to convey information if they h ave no other aria
742 // information on them. If we don't ignore them, they may emit signals expec ted to come from 748 // information on them. If we don't ignore them, they may emit signals expec ted to come from
743 // their parent. In addition, because included spans are GroupRole objects, and GroupRole 749 // their parent. In addition, because included spans are GroupRole objects, and GroupRole
744 // objects are often containers with meaningful information, the inclusion o f a span can have 750 // objects are often containers with meaningful information, the inclusion o f a span can have
745 // the side effect of causing the immediate parent accessible to be ignored. This is especially 751 // the side effect of causing the immediate parent accessible to be ignored. This is especially
746 // problematic for platforms which have distinct roles for textual block ele ments. 752 // problematic for platforms which have distinct roles for textual block ele ments.
(...skipping 1681 matching lines...) Expand 10 before | Expand all | Expand 10 after
2428 if (label && label->renderer()) { 2434 if (label && label->renderer()) {
2429 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2435 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2430 result.unite(labelRect); 2436 result.unite(labelRect);
2431 } 2437 }
2432 } 2438 }
2433 2439
2434 return result; 2440 return result;
2435 } 2441 }
2436 2442
2437 } // namespace blink 2443 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698