Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 710623002: Merge to M39: Correct manual proxy selection for WebSockets. (Closed)

Created:
6 years, 1 month ago by Adam Rice
Modified:
6 years, 1 month ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, amineer
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Correct manual proxy selection for WebSockets. When an HTTPS and/or HTTP proxy was manually configured, WebSocket connections were mistakenly going direct to the origin server. According to RFC6455, WebSocket connections should prefer SOCKS proxies, then HTTPS, then HTTP proxies in that order. Fix the behaviour when proxies are manually selected to match. BUG=426736 TEST=net_unittests, manual R=eroman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/07620c32441e264cf108943282536d8b41fca248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -2 lines) Patch
M net/proxy/proxy_config.h View 1 chunk +8 lines, -2 lines 0 comments Download
M net/proxy/proxy_config.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Adam Rice
+eroman amineer@ says he's on the fence about whether to merge this to M39, but ...
6 years, 1 month ago (2014-11-07 10:40:59 UTC) #2
eroman
I am fine with merging this. I don't expect it will cause any problems (the ...
6 years, 1 month ago (2014-11-07 22:15:21 UTC) #3
eroman
lgtm
6 years, 1 month ago (2014-11-07 22:15:26 UTC) #4
eroman
(You still need merge approval; my LGTM was just to indicate that I am on ...
6 years, 1 month ago (2014-11-07 22:16:01 UTC) #5
Adam Rice
6 years, 1 month ago (2014-11-08 11:15:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07620c32441e264cf108943282536d8b41fca248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698