Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 710593003: Fix change log creation in push script. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix change log creation in push script. BUG=chromium:408523 LOG=n TBR=tandrii@chromium.org TEST=script_test.py Committed: https://code.google.com/p/v8/source/detail?r=25244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M tools/push-to-trunk/common_includes.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 2 chunks +3 lines, -5 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 11 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL. The work-dir feature broke this. All commands, e.g. git, operate in the work dir ...
6 years, 1 month ago (2014-11-10 11:43:02 UTC) #2
Michael Achenbach
Committed patchset #1 (id:1) manually as 25244 (presubmit successful).
6 years, 1 month ago (2014-11-10 11:52:08 UTC) #3
tandrii(chromium)
6 years, 1 month ago (2014-11-10 14:11:11 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698