Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 710553002: aura: Remove WindowTreeHost::PostNativeEvent(). (Closed)

Created:
6 years, 1 month ago by sadrul
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, tdanderson+views_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

aura: Remove WindowTreeHost::PostNativeEvent(). WindowTreeHost::PostNativeEvent() is only used in tests. So remove this from the public API. Instead: . For Win32, directly use PostMessage (this is used in only two places). . For Ozone, use EventSourceTestApi to inject the event (this is equivalent to current code, in terms of not doing the right thing when menus are open). . For X11, introduce aura::test::PostEventToWindowTreeHost() instead, and use it in tests. BUG=none R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c332de7c1838b85e27685bed6c376c36ccb17287

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -129 lines) Patch
M ui/aura/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M ui/aura/test/ui_controls_factory_ozone.cc View 4 chunks +11 lines, -2 lines 0 comments Download
A + ui/aura/test/x11_event_sender.h View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
A ui/aura/test/x11_event_sender.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/aura/window_tree_host_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window_tree_host_ozone.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_ozone.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/window_tree_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M ui/wm/core/nested_accelerator_controller_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sadrul
6 years, 1 month ago (2014-11-07 01:23:11 UTC) #2
sky
https://codereview.chromium.org/710553002/diff/1/ui/aura/test/ui_controls_factory_ozone.cc File ui/aura/test/ui_controls_factory_ozone.cc (right): https://codereview.chromium.org/710553002/diff/1/ui/aura/test/ui_controls_factory_ozone.cc#newcode169 ui/aura/test/ui_controls_factory_ozone.cc:169: void SendEventToProcessor(ui::Event* event) { Is there a reason this ...
6 years, 1 month ago (2014-11-07 15:50:15 UTC) #3
sadrul
https://codereview.chromium.org/710553002/diff/1/ui/aura/test/ui_controls_factory_ozone.cc File ui/aura/test/ui_controls_factory_ozone.cc (right): https://codereview.chromium.org/710553002/diff/1/ui/aura/test/ui_controls_factory_ozone.cc#newcode169 ui/aura/test/ui_controls_factory_ozone.cc:169: void SendEventToProcessor(ui::Event* event) { On 2014/11/07 15:50:14, sky wrote: ...
6 years, 1 month ago (2014-11-07 17:03:15 UTC) #4
sky
Ok, LGTM
6 years, 1 month ago (2014-11-07 22:49:46 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c332de7c1838b85e27685bed6c376c36ccb17287 Cr-Commit-Position: refs/heads/master@{#303315}
6 years, 1 month ago (2014-11-07 22:58:44 UTC) #6
sadrul
6 years, 1 month ago (2014-11-07 22:58:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c332de7c1838b85e27685bed6c376c36ccb17287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698