Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(59)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/copresence/proto/push_message.proto
Issue
710513004
:
Adding GCM support to the copresence component. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/extensions/api/copresence/copresence_api.h
chrome/browser/extensions/api/copresence/copresence_api.cc
components/components_tests.gyp
components/copresence.gypi
components/copresence/BUILD.gn
components/copresence/DEPS
components/copresence/copresence_manager_impl.h
components/copresence/copresence_manager_impl.cc
components/copresence/handlers/gcm_handler.h
components/copresence/handlers/gcm_handler.cc
components/copresence/handlers/gcm_handler_unittest.cc
components/copresence/proto/data.proto
components/copresence/proto/push_message.proto
components/copresence/public/copresence_delegate.h
components/copresence/rpc/rpc_handler.h
components/copresence/rpc/rpc_handler.cc
components/copresence/rpc/rpc_handler_unittest.cc
components/copresence/test/fake_directive_handler.h
components/copresence/test/fake_directive_handler.cc
View unified diff
|
Download patch
« components/copresence/handlers/gcm_handler.cc
('K') |
« components/copresence/proto/data.proto
('k') |
components/copresence/public/copresence_delegate.h »
('j') |
components/copresence/rpc/rpc_handler.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
syntax = "proto2";
2
package copresence;
3
option optimize_for = LITE_RUNTIME;
4
import "data.proto";
5
message PushMessage {
6
enum Type {
7
TYPE_UNKNOWN = 0;
8
SYNC_SETTINGS = 3;
9
OBTAIN_MAC = 5;
10
NOTIFY_MAC = 6;
11
TEST = 7;
12
REPORT = 8;
13
};
14
optional Type type = 1;
15
optional Report report = 9;
16
}
17
message Report {
18
repeated Directive directive = 1;
19
repeated SubscribedMessage subscribed_message = 2;
20
}
OLD
NEW
« components/copresence/handlers/gcm_handler.cc
('K') |
« components/copresence/proto/data.proto
('k') |
components/copresence/public/copresence_delegate.h »
('j') |
components/copresence/rpc/rpc_handler.cc »
('J')
Issue 710513004: Adding GCM support to the copresence component. (Closed)
Created 6 years, 1 month ago by Charlie
Modified 6 years, 1 month ago
Reviewers: rkc, fgorski
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 31
This is Rietveld
408576698