Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: components/autofill/content/browser/content_autofill_driver.cc

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Abstracting the call to WebContents::OpenURL() throuh the AutofillDriver. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/content_autofill_driver.cc
diff --git a/components/autofill/content/browser/content_autofill_driver.cc b/components/autofill/content/browser/content_autofill_driver.cc
index a3bba0f250bb23975b6014820d73b51513c07a75..8742e58fe7f9a607312b78153fbee5919fd66231 100644
--- a/components/autofill/content/browser/content_autofill_driver.cc
+++ b/components/autofill/content/browser/content_autofill_driver.cc
@@ -11,6 +11,7 @@
#include "components/autofill/core/browser/autofill_external_delegate.h"
#include "components/autofill/core/browser/autofill_manager.h"
#include "components/autofill/core/browser/form_structure.h"
+#include "components/autofill/core/common/autofill_constants.h"
#include "components/autofill/core/common/autofill_switches.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
@@ -232,4 +233,12 @@ void ContentAutofillDriver::WasHidden() {
autofill_manager_->client()->HideAutofillPopup();
}
+void ContentAutofillDriver::LinkClicked(
+ WindowOpenDisposition disposition) const {
+ web_contents()->OpenURL(content::OpenURLParams(
Ilya Sherman 2014/11/21 18:41:52 I don't believe that OpenURL is a const method, so
Peter Kasting 2014/11/21 19:42:17 I agree, but the reason this was even possible was
+ GURL(autofill::kHelpURL), content::Referrer(),
+ (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
+ ui::PAGE_TRANSITION_LINK, false));
Ilya Sherman 2014/11/21 18:41:52 I think some of this work belongs in the infobar c
Pritam Nikam 2014/11/24 14:45:54 Done.
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698