[Autofill] Componentize AutofillCCInfoBarDelegate.

components/autofill/content/browser/content_autofill_driver.cc

Index: components/autofill/content/browser/content_autofill_driver.cc
diff --git a/components/autofill/content/browser/content_autofill_driver.cc b/components/autofill/content/browser/content_autofill_driver.cc
index a3bba0f250bb23975b6014820d73b51513c07a75..8742e58fe7f9a607312b78153fbee5919fd66231 100644
--- a/components/autofill/content/browser/content_autofill_driver.cc
+++ b/components/autofill/content/browser/content_autofill_driver.cc
@@ -11,6 +11,7 @@
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/form_structure.h"
+#include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
@@ -232,4 +233,12 @@ void ContentAutofillDriver::WasHidden() {
   autofill_manager_->client()->HideAutofillPopup();
 }
 
+void ContentAutofillDriver::LinkClicked(
+    WindowOpenDisposition disposition) const {
+  web_contents()->OpenURL(content::OpenURLParams(

[Ilya Sherman, 2014/11/21 18:41:52]

I don't believe that OpenURL is a const method, so this entire function should
not be const.

[Peter Kasting, 2014/11/21 19:42:17]

I agree, but the reason this was even possible was that
content::WebContentsObserver has "WebContents* web_contents() const", which
shouldn't be a const function either.

It would be nice to fix this as well, but that may be beyond the scope of this
change.

+      GURL(autofill::kHelpURL), content::Referrer(),
+      (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
+      ui::PAGE_TRANSITION_LINK, false));

[Ilya Sherman, 2014/11/21 18:41:52]

I think some of this work belongs in the infobar class.  I'd implement this
method as

void ContentAutofillDriver::LinkClicked(const GURL& url,
                                        WindowOpenDisposition disposition) {
  web_contents()->OpenURL(content::OpenURLParams(
      url, content::Referrer(), disposition, ui::PAGE_TRANSITION_LINK, false));
}

The remaining code -- i.e. the url constant and the massaging of the disposition
-- belong in the infobar class.

[Pritam Nikam, 2014/11/24 14:45:54]

Done.

+}
+
 }  // namespace autofill