Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: components/autofill/core/browser/autofill_cc_infobar_delegate.h

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Abstracting the call to WebContents::OpenURL() through the AutofillClient. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_cc_infobar_delegate.h
diff --git a/chrome/browser/autofill/autofill_cc_infobar_delegate.h b/components/autofill/core/browser/autofill_cc_infobar_delegate.h
similarity index 70%
rename from chrome/browser/autofill/autofill_cc_infobar_delegate.h
rename to components/autofill/core/browser/autofill_cc_infobar_delegate.h
index 717cd900f5b8f054431e7d15c75e535b5d64b55b..b1653c94aa8f0febf934687292786d668e9560b3 100644
--- a/chrome/browser/autofill/autofill_cc_infobar_delegate.h
+++ b/components/autofill/core/browser/autofill_cc_infobar_delegate.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
-#define CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_
#include "base/basictypes.h"
#include "base/callback.h"
@@ -14,31 +14,35 @@
#include "components/infobars/core/confirm_infobar_delegate.h"
#include "ui/base/window_open_disposition.h"
-class CreditCard;
-class PersonalDataManager;
-class InfoBarService;
+namespace infobars {
+class InfoBarManager;
+}
namespace autofill {
+class AutofillClient;
+
// An InfoBar delegate that enables the user to allow or deny storing credit
// card information gathered from a form submission.
class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
public:
- // Creates an autofill credit card infobar and delegate and adds the infobar
- // to |infobar_service|.
- static void Create(InfoBarService* infobar_service,
+ // Creates an autofill credit card infobar and delegate and add the infobar
Ilya Sherman 2015/01/07 01:58:54 nit: "add" -> "adds"
Ilya Sherman 2015/01/07 01:58:54 nit: "delegate" -> "client"
Pritam Nikam 2015/01/07 05:35:13 Here "delegate" is an infobar delegate.
Pritam Nikam 2015/01/07 05:35:13 Done.
+ // to |infobar_manager|.
Ilya Sherman 2015/01/07 01:58:54 Please document the lifetime expectation, i.e. tha
Pritam Nikam 2015/01/07 05:35:13 Done. I've rephrased it to: "Creates an autofill
+ static void Create(infobars::InfoBarManager* infobar_manager,
+ AutofillClient* autofill_client,
const base::Closure& save_card_callback);
#if defined(UNIT_TEST)
static scoped_ptr<ConfirmInfoBarDelegate> Create(
+ AutofillClient* autofill_client,
const base::Closure& save_card_callback) {
return scoped_ptr<ConfirmInfoBarDelegate>(
- new AutofillCCInfoBarDelegate(save_card_callback));
+ new AutofillCCInfoBarDelegate(autofill_client, save_card_callback));
}
#endif
Ilya Sherman 2015/01/06 23:20:17 nit: Please leave a blank line after this one.
Pritam Nikam 2015/01/07 05:35:13 Done.
-
private:
- explicit AutofillCCInfoBarDelegate(const base::Closure& save_card_callback);
+ AutofillCCInfoBarDelegate(AutofillClient* autofill_client,
+ const base::Closure& save_card_callback);
~AutofillCCInfoBarDelegate() override;
void LogUserAction(AutofillMetrics::InfoBarMetric user_action);
@@ -55,6 +59,10 @@ class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
base::string16 GetLinkText() const override;
bool LinkClicked(WindowOpenDisposition disposition) override;
+ // Performs navigation to handle any link click. |autofill_client_| outlives
+ // the lifetime of |this| object.
+ AutofillClient* autofill_client_;
Ilya Sherman 2015/01/07 01:58:54 nit: Please change the type to "AutofillClient* co
Pritam Nikam 2015/01/07 05:35:13 Done.
+
// The callback to save credit card if the user accepts the infobar.
base::Closure save_card_callback_;
@@ -68,4 +76,4 @@ class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
} // namespace autofill
-#endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_
« no previous file with comments | « components/autofill/core/browser/DEPS ('k') | components/autofill/core/browser/autofill_cc_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698