[Autofill] Componentize AutofillCCInfoBarDelegate.

components/autofill/core/browser/autofill_manager.cc

Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index d6c41fed59ea92da22c6ebda49c629475ce94a7d..1388eeb74c16ca5c6bda2899e282341bccec4726 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -21,6 +21,7 @@
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
+#include "components/autofill/core/browser/autofill_cc_infobar_delegate.h"
 #include "components/autofill/core/browser/autofill_client.h"
 #include "components/autofill/core/browser/autofill_data_model.h"
 #include "components/autofill/core/browser/autofill_external_delegate.h"
@@ -671,11 +672,11 @@ void AutofillManager::ImportFormData(const FormStructure& submitted_form) {
   // If credit card information was submitted, we need to confirm whether to
   // save it.
   if (imported_credit_card) {
-    client_->ConfirmSaveCreditCard(
+    AutofillCCInfoBarDelegate::Create(

[Peter Kasting, 2014/12/23 21:20:35]

It seems like the way we abstracted this entire call behind a client method
before was a better route.

If this is abstracted behind a client call, we don't need to add the
GetInfoBarManager() method on the client, because the chrome-side code that
implements this can just do that directly to pass the value to
AutofillCCInfoBarDelegate::Create().  This also prevents any possible null-deref
in test code, where the implementation of GetInfoBarManager() returns null but
the infobar delegate doesn't null-check the provided pointer; instead, if this
is abstracted, the test implementation of that method can just do nothing.

[Pritam Nikam, 2014/12/24 11:16:57]

Done.

Restored back ConfirmSaveCreditCard().

+        client_->GetInfoBarManager(), driver_,
         base::Bind(
             base::IgnoreResult(&PersonalDataManager::SaveImportedCreditCard),
-            base::Unretained(personal_data_),
-            *imported_credit_card));
+            base::Unretained(personal_data_), *imported_credit_card));
   }
 }