Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: components/autofill/content/browser/content_autofill_driver.h

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Sylvain's review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/content_autofill_driver.h
diff --git a/components/autofill/content/browser/content_autofill_driver.h b/components/autofill/content/browser/content_autofill_driver.h
index cb35d811d533fa362c108a52dccfca01ce96049d..8f4604c1bc728e4bd0ec0143514362a978ed2151 100644
--- a/components/autofill/content/browser/content_autofill_driver.h
+++ b/components/autofill/content/browser/content_autofill_driver.h
@@ -17,6 +17,7 @@
namespace content {
class BrowserContext;
class RenderFrameHost;
+class WebContents;
struct FrameNavigateParams;
struct LoadCommittedDetails;
}
@@ -61,6 +62,7 @@ class ContentAutofillDriver : public AutofillDriver {
void RendererShouldFillFieldWithValue(const base::string16& value) override;
void RendererShouldPreviewFieldWithValue(
const base::string16& value) override;
+ void LinkClicked(const GURL& url, WindowOpenDisposition disposition) override;
// Handles a message that came from the associated render frame.
bool HandleMessage(const IPC::Message& message);
@@ -82,6 +84,9 @@ class ContentAutofillDriver : public AutofillDriver {
void SetAutofillManager(scoped_ptr<AutofillManager> manager);
private:
+ // Gets the WebContents instance associated with the driver.
+ content::WebContents* web_contents();
Peter Kasting 2014/12/23 21:20:34 unix_hacker()-named functions should be simple inl
Pritam Nikam 2014/12/24 11:16:57 Done. Renamed to GetWebContents().
+
// Weak ref to the RenderFrameHost the driver is associated with. Should
// always be non-NULL and valid for lifetime of |this|.
content::RenderFrameHost* const render_frame_host_;

Powered by Google App Engine
This is Rietveld 408576698