[Autofill] Componentize AutofillCCInfoBarDelegate.

android_webview/native/aw_autofill_client.h

Index: android_webview/native/aw_autofill_client.h
diff --git a/android_webview/native/aw_autofill_client.h b/android_webview/native/aw_autofill_client.h
index a6158fa769bc87c44c4f8c441e080da5d0aa2ea5..8361424901c51ca213e075e5ffa38ca948d3611e 100644
--- a/android_webview/native/aw_autofill_client.h
+++ b/android_webview/native/aw_autofill_client.h
@@ -30,6 +30,10 @@ namespace content {
 class WebContents;
 }
 
+namespace infobars {
+class InfoBarManager;
+}
+
 namespace gfx {
 class RectF;
 }
@@ -62,8 +66,6 @@ class AwAutofillClient : public autofill::AutofillClient,
   virtual void HideRequestAutocompleteDialog() override;
   virtual void ShowAutofillSettings() override;
   virtual void ShowUnmaskPrompt() override;
-  virtual void ConfirmSaveCreditCard(
-      const base::Closure& save_card_callback) override;
   virtual bool HasCreditCardScanFeature() override;
   virtual void ScanCreditCard(const CreditCardScanCallback& callback) override;
   virtual void ShowRequestAutocompleteDialog(
@@ -87,6 +89,7 @@ class AwAutofillClient : public autofill::AutofillClient,
       const base::string16& autofilled_value,
       const base::string16& profile_full_name) override;
   virtual void OnFirstUserGestureObserved() override;
+  virtual infobars::InfoBarManager* GetInfoBarManager() override;

[sdefresne, 2014/12/23 08:43:44]

style: shouldn't you remove the "virtual" there since a method should only have
one of "virtual", "override" or "final"? Not sure since this is an android file.

[Pritam Nikam, 2014/12/23 09:13:35]

Even I was wondering what to keep here. However, just to keep things align with
rest of the virtual function listed in this file, I've kept |virtual| and
|override| both.

[Peter Kasting, 2014/12/23 21:20:34]

The correct style in Chromium now is to use only one of the modifiers, so just
"override".

However, we should be correcting this in an automated fashion over time, so
whether you want to bother to change everything in this file now is up to you. 
I think leaving this as you have it now is fine too.

[Pritam Nikam, 2014/12/24 11:16:57]

I'll keep this as it is for now.

 
   void SuggestionSelected(JNIEnv* env, jobject obj, jint position);