Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: components/autofill/core/browser/autofill_client.h

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return nullptr for CreateInfoBar() in test_autofill_client.cc. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_client.h
diff --git a/components/autofill/core/browser/autofill_client.h b/components/autofill/core/browser/autofill_client.h
index 452c793b032a280d98388cd04ac0769e0409f540..28546b021d7d92e311867ec5829b5b655d5c538c 100644
--- a/components/autofill/core/browser/autofill_client.h
+++ b/components/autofill/core/browser/autofill_client.h
@@ -9,6 +9,7 @@
#include "base/callback_forward.h"
#include "base/i18n/rtl.h"
+#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
@@ -17,11 +18,17 @@ class Rect;
class RectF;
}
+namespace infobars {
+class InfoBar;
+}
+
+class ConfirmInfoBarDelegate;
class GURL;
class PrefService;
namespace autofill {
+class AutofillManager;
class AutofillMetrics;
class AutofillPopupDelegate;
class AutofillWebDataService;
@@ -73,8 +80,13 @@ class AutofillClient {
virtual void ShowAutofillSettings() = 0;
// Run |save_card_callback| if the credit card should be imported as personal
- // data. |metric_logger| can be used to log user actions.
+ // data. |metric_logger| can be used to log user actions. |autofill_manager|
+ // is a container for AutofillDriver and AutofillClient. It lives till the
+ // associated web contents persists.
+ // AutofillClient abstracts the InfoBar creation and AutofillDriver is used
+ // to perform navigations to handle any link clicks performed on that InfoBar.
virtual void ConfirmSaveCreditCard(
+ AutofillManager* autofill_manager,
const AutofillMetrics& metric_logger,
const base::Closure& save_card_callback) = 0;
@@ -125,6 +137,10 @@ class AutofillClient {
virtual void DidFillOrPreviewField(
const base::string16& autofilled_value,
const base::string16& profile_full_name) = 0;
+
+ // Returns a translate infobar that owns |delegate|.
Ilya Sherman 2014/12/03 20:00:21 Why a translate infobar?
Pritam Nikam 2014/12/04 15:37:30 Done.
+ virtual scoped_ptr<infobars::InfoBar> CreateInfoBar(
+ scoped_ptr<ConfirmInfoBarDelegate> delegate) = 0;
Ilya Sherman 2014/12/03 20:00:21 I suspect that this method is not appropriate, but
};
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698