Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: components/autofill/core/browser/autofill_cc_infobar_delegate.h

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return nullptr for CreateInfoBar() in test_autofill_client.cc. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_cc_infobar_delegate.h
diff --git a/chrome/browser/autofill/autofill_cc_infobar_delegate.h b/components/autofill/core/browser/autofill_cc_infobar_delegate.h
similarity index 73%
rename from chrome/browser/autofill/autofill_cc_infobar_delegate.h
rename to components/autofill/core/browser/autofill_cc_infobar_delegate.h
index 2fd4e799708ed9a047d277f78b0d16221bca1729..31cca940c301dbeddbbc04b1215066209f3776fd 100644
--- a/chrome/browser/autofill/autofill_cc_infobar_delegate.h
+++ b/components/autofill/core/browser/autofill_cc_infobar_delegate.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
-#define CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_
#include "base/basictypes.h"
#include "base/callback.h"
@@ -14,33 +14,39 @@
#include "components/infobars/core/confirm_infobar_delegate.h"
#include "ui/base/window_open_disposition.h"
-class CreditCard;
-class PersonalDataManager;
-class InfoBarService;
+namespace infobars {
+class InfoBarManager;
+}
namespace autofill {
+class AutofillManager;
+class AutofillDriver;
+
// An InfoBar delegate that enables the user to allow or deny storing credit
// card information gathered from a form submission.
class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
public:
// Creates an autofill credit card infobar and delegate and adds the infobar
- // to |infobar_service|.
- static void Create(InfoBarService* infobar_service,
+ // to |infobar_manager|.
+ static void Create(infobars::InfoBarManager* infobar_manager,
+ AutofillManager* autofill_manager,
const AutofillMetrics* metric_logger,
const base::Closure& save_card_callback);
#if defined(UNIT_TEST)
static scoped_ptr<ConfirmInfoBarDelegate> Create(
+ AutofillDriver* autofill_driver,
const AutofillMetrics* metric_logger,
const base::Closure& save_card_callback) {
- return scoped_ptr<ConfirmInfoBarDelegate>(
- new AutofillCCInfoBarDelegate(metric_logger, save_card_callback));
+ return scoped_ptr<ConfirmInfoBarDelegate>(new AutofillCCInfoBarDelegate(
+ autofill_driver, metric_logger, save_card_callback));
}
#endif
private:
- AutofillCCInfoBarDelegate(const AutofillMetrics* metric_logger,
+ AutofillCCInfoBarDelegate(AutofillDriver* autofill_driver,
+ const AutofillMetrics* metric_logger,
const base::Closure& save_card_callback);
~AutofillCCInfoBarDelegate() override;
@@ -58,6 +64,9 @@ class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
base::string16 GetLinkText() const override;
bool LinkClicked(WindowOpenDisposition disposition) override;
+ // Performs navigations to handle any link clicks.
+ AutofillDriver* autofill_driver_;
Ilya Sherman 2014/12/03 20:00:21 Please document lifetime expectations. Are you co
Pritam Nikam 2014/12/04 15:37:30 Done.
+
// For logging UMA metrics.
// Weak reference. Owned by the AutofillManager that initiated this infobar.
const AutofillMetrics* metric_logger_;
@@ -75,4 +84,4 @@ class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
} // namespace autofill
-#endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698