Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: android_webview/native/aw_autofill_client.cc

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Ilya's review inputs. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_autofill_client.h" 5 #include "android_webview/native/aw_autofill_client.h"
6 6
7 #include "android_webview/browser/aw_browser_context.h" 7 #include "android_webview/browser/aw_browser_context.h"
8 #include "android_webview/browser/aw_content_browser_client.h" 8 #include "android_webview/browser/aw_content_browser_client.h"
9 #include "android_webview/browser/aw_form_database_service.h" 9 #include "android_webview/browser/aw_form_database_service.h"
10 #include "android_webview/browser/aw_pref_store.h" 10 #include "android_webview/browser/aw_pref_store.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 160
161 void AwAutofillClient::DidFillOrPreviewField( 161 void AwAutofillClient::DidFillOrPreviewField(
162 const base::string16& autofilled_value, 162 const base::string16& autofilled_value,
163 const base::string16& profile_full_name) { 163 const base::string16& profile_full_name) {
164 } 164 }
165 165
166 void AwAutofillClient::OnFirstUserGestureObserved() { 166 void AwAutofillClient::OnFirstUserGestureObserved() {
167 NOTIMPLEMENTED(); 167 NOTIMPLEMENTED();
168 } 168 }
169 169
170 bool AwAutofillClient::LinkClicked(WindowOpenDisposition disposition) {
171 return false;
Peter Kasting 2015/01/07 20:26:29 Nit: Shouldn't this also NOTIMPLEMENTED(), as we e
Pritam Nikam 2015/01/08 06:15:41 Done.
172 }
173
170 void AwAutofillClient::SuggestionSelected(JNIEnv* env, 174 void AwAutofillClient::SuggestionSelected(JNIEnv* env,
171 jobject object, 175 jobject object,
172 jint position) { 176 jint position) {
173 if (delegate_) { 177 if (delegate_) {
174 delegate_->DidAcceptSuggestion(suggestions_[position].value, 178 delegate_->DidAcceptSuggestion(suggestions_[position].value,
175 suggestions_[position].frontend_id); 179 suggestions_[position].frontend_id);
176 } 180 }
177 } 181 }
178 182
179 void AwAutofillClient::HideRequestAutocompleteDialog() { 183 void AwAutofillClient::HideRequestAutocompleteDialog() {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 const GURL& source_url, 216 const GURL& source_url,
213 const ResultCallback& callback) { 217 const ResultCallback& callback) {
214 NOTIMPLEMENTED(); 218 NOTIMPLEMENTED();
215 } 219 }
216 220
217 bool RegisterAwAutofillClient(JNIEnv* env) { 221 bool RegisterAwAutofillClient(JNIEnv* env) {
218 return RegisterNativesImpl(env); 222 return RegisterNativesImpl(env);
219 } 223 }
220 224
221 } // namespace android_webview 225 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698