[Autofill] Componentize AutofillCCInfoBarDelegate.

components/autofill/core/browser/autofill_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CLIENT_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CLIENT_H_
 
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/i18n/rtl.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 
 namespace content {
 class RenderFrameHost;
 }
 
 namespace gfx {
 class Rect;
 class RectF;
 }
 
+namespace infobars {
+class InfoBar;
+}
+
+class ConfirmInfoBarDelegate;
 class GURL;
 class PrefService;
 
 namespace autofill {
 
-class AutofillMetrics;
+class AutofillManager;
 class AutofillPopupDelegate;
 class AutofillWebDataService;
 class CreditCard;
 class FormStructure;
 class PersonalDataManager;
 struct FormData;
 
 // A client interface that needs to be supplied to the Autofill component by the
 // embedder.
 //
@@ skipping 34 matching lines @@
   virtual void HideRequestAutocompleteDialog() = 0;
 
   // Causes the Autofill settings UI to be shown.
   virtual void ShowAutofillSettings() = 0;
 
   // A user has attempted to use a masked card. Prompt them for further
   // information to proceed.
   virtual void ShowUnmaskPrompt() = 0;
 
   // Run |save_card_callback| if the credit card should be imported as personal
-  // data. |metric_logger| can be used to log user actions.
+  // data. |autofill_manager| is a container for AutofillDriver and
+  // AutofillClient. It lives till the associated web contents persists.
+  // AutofillClient abstracts the InfoBar creation and AutofillDriver is used to
+  // perform navigations to handle any link clicks performed on that InfoBar.
   virtual void ConfirmSaveCreditCard(
+      AutofillManager* autofill_manager,
       const base::Closure& save_card_callback) = 0;
 
   // Returns true if both the platform and the device support scanning credit
   // cards. Should be called before ScanCreditCard().
   virtual bool HasCreditCardScanFeature() = 0;
 
   // Shows the user interface for scanning a credit card. Invokes the |callback|
   // when a credit card is scanned successfully. Should be called only if
   // HasCreditCardScanFeature() returns true.
   virtual void ScanCreditCard(const CreditCardScanCallback& callback) = 0;
@@ skipping 33 matching lines @@
       content::RenderFrameHost* rfh,
       const std::vector<autofill::FormStructure*>& forms) = 0;
 
   // Inform the client that the field has been filled.
   virtual void DidFillOrPreviewField(
       const base::string16& autofilled_value,
       const base::string16& profile_full_name) = 0;
 
   // Informs the client that a user gesture has been observed.
   virtual void OnFirstUserGestureObserved() = 0;
+
+  // Returns the autofill infobar that owns |delegate|.
+  virtual scoped_ptr<infobars::InfoBar> CreateInfoBar(

[blundell, 2014/12/12 16:03:07]

Can't you get rid of this now?

[Pritam Nikam, 2014/12/12 16:19:57]

No. Still the same linker error if I revert this interface.

// ---[snap] ---//
src/third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: hidden symbol
'ConfirmInfoBarDelegate::CreateInfoBar(scoped_ptr<ConfirmInfoBarDelegate,
base::DefaultDeleter<ConfirmInfoBarDelegate> >)' in
obj/chrome/libbrowser_ui.a(obj/chrome/browser/ui/views/infobars/browser_ui.confirm_infobar.o)
is referenced by DSO lib/libpolicy_component.so

+      scoped_ptr<ConfirmInfoBarDelegate> delegate) = 0;
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CLIENT_H_