[Autofill] Componentize AutofillCCInfoBarDelegate.

components/autofill/core/browser/autofill_cc_infobar_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
-#define CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "ui/base/window_open_disposition.h"
 
-class CreditCard;
-class PersonalDataManager;
-class InfoBarService;
+namespace infobars {
+class InfoBarManager;
+}
 
 namespace autofill {
 
+class AutofillDriver;
+class AutofillManager;
+
 // An InfoBar delegate that enables the user to allow or deny storing credit
 // card information gathered from a form submission.
 class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
  public:
   // Creates an autofill credit card infobar and delegate and adds the infobar
-  // to |infobar_service|.
-  static void Create(InfoBarService* infobar_service,
+  // to |infobar_manager|.
+  static void Create(infobars::InfoBarManager* infobar_manager,
+                     AutofillManager* autofill_manager,
                      const base::Closure& save_card_callback);
 
 #if defined(UNIT_TEST)
   static scoped_ptr<ConfirmInfoBarDelegate> Create(
+      AutofillDriver* autofill_driver,
       const base::Closure& save_card_callback) {
     return scoped_ptr<ConfirmInfoBarDelegate>(
-        new AutofillCCInfoBarDelegate(save_card_callback));
+        new AutofillCCInfoBarDelegate(autofill_driver, save_card_callback));
   }
 #endif
 
  private:
-  explicit AutofillCCInfoBarDelegate(const base::Closure& save_card_callback);
+  AutofillCCInfoBarDelegate(AutofillDriver* autofill_driver,
+                            const base::Closure& save_card_callback);
   ~AutofillCCInfoBarDelegate() override;
 
   void LogUserAction(AutofillMetrics::InfoBarMetric user_action);
 
   // ConfirmInfoBarDelegate:
   void InfoBarDismissed() override;
   int GetIconID() const override;
   Type GetInfoBarType() const override;
   bool ShouldExpireInternal(const NavigationDetails& details) const override;
   base::string16 GetMessageText() const override;
   base::string16 GetButtonLabel(InfoBarButton button) const override;
   bool Accept() override;
   bool Cancel() override;
   base::string16 GetLinkText() const override;
   bool LinkClicked(WindowOpenDisposition disposition) override;
 
+  // Performs navigations to handle any link clicks.
+  // It is associated with a render frame within the WebContents and lives as
+  // long as it's tab persists.

[Ilya Sherman, 2014/12/12 22:24:21]

The relevant lifetime expectation is "The driver must outlive the infobar." 
Given that both are destroyed around the time that the tab is destroyed, what is
guaranteeing that the infobar is destroyed first?

[Pritam Nikam, 2014/12/15 11:16:14]

Perhaps, AutofillDriver is destroyed before infobar.

Please correct my understanding, AutofillDrivers are per RenderFrame instance
within the WebContents, and supposedly get destroyed early. Moreover, code
snippet of WebContentsImpl dtor [A] shows that renderer frames destroy (and
eventually bringing down AutofillDriver) before it destroys InfoBarDelegate [B].

[A].
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/we...

[B].
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/we...

[Ilya Sherman, 2014/12/16 00:37:21]

It sounds like you're saying that there's no guarantee that the driver outlives
the infobar.  In that case, please use a WeakPtr, or find some other way to
guarantee that the infobar class cannot attempt to read freed memory.

+  AutofillDriver* autofill_driver_;
+
   // The callback to save credit card if the user accepts the infobar.
   base::Closure save_card_callback_;
 
   // Did the user ever explicitly accept or dismiss this infobar?
   bool had_user_interaction_;
 
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, CreditCardInfoBar);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillCCInfoBarDelegate);
 };
 
 }  // namespace autofill
 
-#endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_CC_INFOBAR_DELEGATE_H_