Issue 71043002: Try a different arbitrary SkGlyphCache cap (64 -> 256)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 71043002: Try a different arbitrary SkGlyphCache cap (64 -> 256) (Closed)

Created:
7 years, 1 month ago by jamesr

Modified:
7 years, 1 month ago

Reviewers:
cpu_(ooo_6.6-7.5), reed1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Try a different arbitrary SkGlyphCache cap (64 -> 256) We're hitting a lot of crashes in skia::CreateCanvas that may be due to GDI handle exhaustion. This picks a different arbitrary limit for the number of entries in this cache to try to see if the crashes are correlated. Changing this cap from 2048->64 was perf neutral on the bots, so 64->256 is also expected to be neutral. TBR=reed NOTRY=true BUG=275046, 314387 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234702

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	skia/skia_library.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/71043002/30001

7 years, 1 month ago (2013-11-13 01:32:48 UTC) #3

Message was sent while issue was closed.

Change committed as 234702

Expand Messages | Collapse Messages