Does not crash with unexpected function in debug build.

Does not crash with unexpected function in debug build.

Add apitest for InputUI extension API.


BUG=Crashes when extension calls a undefined function
TEST=Manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88390

[Peng, 2011-05-31 20:37:51]

On 2011/05/31 20:22:42, Peng wrote:

http://codereview.chromium.org/7084033/diff/9004/chrome/browser/resources/key...

In JS side, it will catch exception if the inputUI.register is not defined. So
It is better that the browser just prints log in debug build instead of crash.

[Peng, 2011-06-02 18:47:05]

Hi Aaron, Could you please review this CL? Thanks.

[Mihai Parparita -not on Chrome, 2011-06-02 19:06:57]

Aaron's on sabbatical, Matt might have an opinion on this.

[Peng, 2011-06-02 19:53:04]

On 2011/06/02 19:06:57, Mihai Parparita wrote:
> Aaron's on sabbatical, Matt might have an opinion on this.

Thanks.

Hi Matt, Please review this CL.

[Matt Perry, 2011-06-03 19:43:17]

As we discussed on IM, I think this is the wrong approach. Your goal is to deal
with platform-specific APIs. Rather than ignoring missing extension functions,
we should instead avoid exposing these APIs to the extension at all if they are
not defined for the platform.

Here's how we can do this:
1. Add a "platforms": ["chromeos"] key to extension_api.json. Declare this on
the experimental.input namespace and any others that are chromeos specific.
2. In extension_process_bindings.js, where we process the api.json (search for
apiDefinitions.forEach), skip any namespaces that have a platform that doesn't
match.
3. You'll need to define a native function in extension_process_bindings.cc/.js
that returns a platform string to the JS.

After doing that, chrome.experimental.input should be undefined on all platforms
other than chromeos.

[Peng, 2011-06-06 20:20:40]

Hi Matt, I updated the CL. Please review it again. Thanks.

[Matt Perry, 2011-06-07 00:15:52]

Can we add an apitest for this?

http://codereview.chromium.org/7104002/diff/13001/chrome/renderer/resources/e...
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/7104002/diff/13001/chrome/renderer/resources/e...
chrome/renderer/resources/extension_process_bindings.js:526: var platform =
"unknown";
nit: can you move this block into a separate getPlatform function?

[Peng, 2011-06-07 19:17:30]

Hi Matt, I added a simple apitest for inputUI. Please check it. Thanks.

http://codereview.chromium.org/7104002/diff/13001/chrome/renderer/resources/e...
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/7104002/diff/13001/chrome/renderer/resources/e...
chrome/renderer/resources/extension_process_bindings.js:526: var platform =
"unknown";
On 2011/06/07 00:15:52, Matt Perry wrote:
> nit: can you move this block into a separate getPlatform function?

Done.

[Matt Perry, 2011-06-07 19:35:39]

LGTM

[commit-bot: I haz the power, 2011-06-07 19:52:58]

Presubmit check for 7104002-20002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **

This change modifies file(s) which the extension docs depend on. You must
rebuild the extension docs.

Build by running the build.py script in chrome/common/extensions/docs/build/.

Be sure to include any modified resulting static files
(/common/extension/docs/*.html) in your final changelist.

[commit-bot: I haz the power, 2011-06-08 16:00:26]

Presubmit check for 7104002-20002 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 41, in
<module>
    sys.exit(presubmit_support.Main(None))
  File "/b/depot_tools/presubmit_support.py", line 1245, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1092, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1007, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 128, in CheckChangeOnCommit
  File "<string>", line 45, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 890, in
PanProjectChecks
    input_api, output_api, source_file_filter=None))
  File "/b/depot_tools/presubmit_canned_checks.py", line 751, in CheckOwners
    approvers_plus_owner)
  File "/b/depot_tools/owners.py", line 93, in files_not_covered_by
    self._load_data_needed_for(files)
  File "/b/depot_tools/owners.py", line 136, in _load_data_needed_for
    self._read_owners_in_dir(dirpath)
  File "/b/depot_tools/owners.py", line 164, in _read_owners_in_dir
    'or an email address: "%s"' % line))
owners.SyntaxErrorInOwnersFile:
/mnt/data/b/commit-queue/workdir/chromium/chrome/common/extensions/api/OWNERS:2
syntax error: line is not a comment, a "set" directive, or an email address: ""
Sending crash report ...
  exception: /mnt/data/b/commit-queue/workdir/chromium/chrome/c
  args: ['/mnt/data/b/commit-queue/verification/presubmit_shim.py', '--commit',
'--author', 'penghuang@chromium.org', '--issue', '7104002', '--patchset',
'20002', '--name', '7104002-20002', '--description', 'Does not crash with
unexpected function in debug build.\n\nAdd apitest for InputUI extension
API.\n\n\nBUG=Crashes when extension calls a undefined
function\nTEST=Manually\n', '--rietveld_url', 'http://codereview.chromium.org',
'chrome/browser/extensions/extension_input_ui_apitest.cc',
'chrome/test/data/extensions/api_test/input_ui/other/test.js',
'chrome/renderer/resources/extension_process_bindings.js',
'chrome/test/data/extensions/api_test/input_ui/other/test.html',
'chrome/test/data/extensions/api_test/input_ui/chromeos_touch/test.js',
'chrome/test/data/extensions/api_test/input_ui/chromeos_touch/test.html',
'chrome/common/extensions/api/extension_api.json',
'chrome/test/data/extensions/api_test/input_ui/other/manifest.json',
'chrome/test/data/extensions/api_test/input_ui/chromeos_touch/manifest.json',
'chrome/chrome_tests.gypi', '--rietveld_email', 'commit-bot@chromium.org',
'--rietveld_password', '/!88rPXt1,6SGdp']
  stack:   File "/mnt/data/b/commit-queue/verification/pres
  host: vm105-m4.golo.chromium.org
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) 
[GCC 4.
  user: chrome-bot
  cwd: /mnt/data/b/commit-queue/workdir/chromium
A stack trace has been sent to the maintainers.

[commit-bot: I haz the power, 2011-06-08 19:58:38]

Presubmit check for 7104002-20002 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 43, in
<module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1245, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1092, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1007, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 128, in CheckChangeOnCommit
  File "<string>", line 45, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 890, in
PanProjectChecks
    input_api, output_api, source_file_filter=None))
  File "/b/depot_tools/presubmit_canned_checks.py", line 751, in CheckOwners
    approvers_plus_owner)
  File "/b/depot_tools/owners.py", line 93, in files_not_covered_by
    self._load_data_needed_for(files)
  File "/b/depot_tools/owners.py", line 136, in _load_data_needed_for
    self._read_owners_in_dir(dirpath)
  File "/b/depot_tools/owners.py", line 164, in _read_owners_in_dir
    'or an email address: "%s"' % line))
owners.SyntaxErrorInOwnersFile:
/mnt/data/b/commit-queue/workdir/chromium/chrome/common/extensions/api/OWNERS:2
syntax error: line is not a comment, a "set" directive, or an email address: ""
Sending crash report ...
  exception: /mnt/data/b/commit-queue/workdir/chromium/chrome/c
  args: ['/mnt/data/b/commit-queue/verification/presubmit_shim.py', '--commit',
'--author', 'penghuang@chromium.org', '--issue', '7104002', '--patchset',
'20002', '--name', '7104002-20002', '--description', 'Does not crash with
unexpected function in debug build.\n\nAdd apitest for InputUI extension
API.\n\n\nBUG=Crashes when extension calls a undefined
function\nTEST=Manually\n', '--rietveld_url', 'http://codereview.chromium.org',
'chrome/browser/extensions/extension_input_ui_apitest.cc',
'chrome/test/data/extensions/api_test/input_ui/other/test.js',
'chrome/renderer/resources/extension_process_bindings.js',
'chrome/test/data/extensions/api_test/input_ui/other/test.html',
'chrome/test/data/extensions/api_test/input_ui/chromeos_touch/test.js',
'chrome/test/data/extensions/api_test/input_ui/chromeos_touch/test.html',
'chrome/common/extensions/api/extension_api.json',
'chrome/test/data/extensions/api_test/input_ui/other/manifest.json',
'chrome/test/data/extensions/api_test/input_ui/chromeos_touch/manifest.json',
'chrome/chrome_tests.gypi']
  stack:   File "/mnt/data/b/commit-queue/verification/pres
  host: vm105-m4.golo.chromium.org
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) 
[GCC 4.
  user: chrome-bot
  cwd: /mnt/data/b/commit-queue/workdir/chromium
A stack trace has been sent to the maintainers.