Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 710383002: Remove preload support from the MemoryCache (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove preload support from the MemoryCache We never issue preloads, so this is all dead code. R=esprehn@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d5cebbf6ab6236421132e1af562f0b6091c81272

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -191 lines) Patch
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/fetch/FetchRequest.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/fetch/FetchRequest.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/fetch/MemoryCache.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/fetch/Resource.h View 3 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/fetch/Resource.cpp View 4 chunks +2 lines, -12 lines 2 comments Download
M sky/engine/core/fetch/ResourceFetcher.h View 4 chunks +1 line, -9 lines 0 comments Download
M sky/engine/core/fetch/ResourceFetcher.cpp View 10 chunks +7 lines, -137 lines 0 comments Download
M sky/engine/public/web/WebCachedURLRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebCachedURLRequest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-11 17:38:48 UTC) #1
esprehn
lgtm, one comment. https://codereview.chromium.org/710383002/diff/1/sky/engine/core/fetch/Resource.cpp File sky/engine/core/fetch/Resource.cpp (left): https://codereview.chromium.org/710383002/diff/1/sky/engine/core/fetch/Resource.cpp#oldcode243 sky/engine/core/fetch/Resource.cpp:243: if (!m_error.isNull() && (m_error.isCancellation() || !isPreloaded())) ...
6 years, 1 month ago (2014-11-11 17:52:06 UTC) #3
abarth-chromium
https://codereview.chromium.org/710383002/diff/1/sky/engine/core/fetch/Resource.cpp File sky/engine/core/fetch/Resource.cpp (left): https://codereview.chromium.org/710383002/diff/1/sky/engine/core/fetch/Resource.cpp#oldcode243 sky/engine/core/fetch/Resource.cpp:243: if (!m_error.isNull() && (m_error.isCancellation() || !isPreloaded())) On 2014/11/11 at ...
6 years, 1 month ago (2014-11-11 17:54:15 UTC) #4
abarth-chromium
6 years, 1 month ago (2014-11-11 17:57:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d5cebbf6ab6236421132e1af562f0b6091c81272.

Powered by Google App Engine
This is Rietveld 408576698