LevelDB: Using base::File for all file I/O

third_party/leveldatabase/chromium_logger.h

Index: third_party/leveldatabase/chromium_logger.h
diff --git a/third_party/leveldatabase/chromium_logger.h b/third_party/leveldatabase/chromium_logger.h
index 2967abc61ee7bb2a3ae6ab4c72a6a7de0a60c736..649b19e0db211cf2d34ccc0791974260ba27b3f9 100644
--- a/third_party/leveldatabase/chromium_logger.h
+++ b/third_party/leveldatabase/chromium_logger.h
@@ -5,10 +5,7 @@
 #ifndef THIRD_PARTY_LEVELDATABASE_CHROMIUM_LOGGER_H_
 #define THIRD_PARTY_LEVELDATABASE_CHROMIUM_LOGGER_H_
 
-#include <stdio.h>
-
-#include <algorithm>
-
+#include "base/files/file.h"
 #include "base/format_macros.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
@@ -18,10 +15,8 @@ namespace leveldb {
 
 class ChromiumLogger : public Logger {
  public:
-  explicit ChromiumLogger(FILE* f) : file_(f) {}
-  virtual ~ChromiumLogger() {
-    fclose(file_);
-  }
+  explicit ChromiumLogger(base::File* f) : file_(f) {}
+  virtual ~ChromiumLogger() {}
   virtual void Logv(const char* format, va_list ap) {
     const base::PlatformThreadId thread_id =
         ::base::PlatformThread::CurrentId();
@@ -79,8 +74,7 @@ class ChromiumLogger : public Logger {
       }
 
       assert(p <= limit);
-      fwrite(base, 1, p - base, file_);
-      fflush(file_);

[jsbell, 2014/11/12 01:04:04]

Removed because base::File I/O is not buffered?

[cmumford, 2014/11/12 20:59:32]

Yes, exactly.

+      file_->WriteAtCurrentPos(base, p - base);
       if (base != buffer) {
         delete[] base;
       }
@@ -89,7 +83,7 @@ class ChromiumLogger : public Logger {
   }
 
  private:
-  FILE* file_;
+  scoped_ptr<base::File> file_;
 };
 
 }  // namespace leveldb