third_party/leveldatabase/README.chromium - Issue 710373002: LevelDB: Using base::File for all file I/O

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/leveldatabase/README.chromium

Issue 710373002: LevelDB: Using base::File for all file I/O (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment for GetDirectoryEntries, using ReadAtCurrentPosNoBestEffort Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/leveldatabase/README.chromium

diff --git a/third_party/leveldatabase/README.chromium b/third_party/leveldatabase/README.chromium

index 6a64e01fd5bdcd19023f7a9657cb239fb22bfe8c..5d598d7bd615ac266a3691191090fb9f3b78d7c6 100644

--- a/third_party/leveldatabase/README.chromium

+++ b/third_party/leveldatabase/README.chromium

@@ -12,8 +12,7 @@ FileSystem API implementation and others.

Local Additions:

* gyp file for building in chromium

-* port/port_chromium.{h,cc}, env_chromium.{h,cc}, env_chromium_stdio.{h,cc}, and

- env_chromium_win.{h,cc} provide (POSIX and Windows respectively) chromium

+* port/port_chromium.{h,cc} and env_chromium.{h,cc} provide chromium

implementations of primitives used by leveldb. E.g. threading, file handling,

etc. env_chromium.h allows re-use of some utility functions.

* chromium_logger.h was copied from src/util/posix_logger.h and updated to use