Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: test/mjsunit/es6/mirror-iterators.js

Issue 710273002: Expose internal properties of map/set iterators via mirrors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime/runtime-collections.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug 5 // Flags: --expose-debug-as debug
6 // Test the mirror object for collection iterators. 6 // Test the mirror object for collection iterators.
7 7
8 function testIteratorMirror(iter, offset, expected, opt_limit) { 8 function testIteratorMirror(iter, offset, expected, opt_limit) {
9 while (offset-- > 0) iter.next(); 9 while (offset-- > 0) iter.next();
10 10
11 var mirror = debug.MakeMirror(iter); 11 var mirror = debug.MakeMirror(iter);
12 assertTrue(mirror.isIterator()); 12 assertTrue(mirror.isIterator());
13 13
14 var preview = mirror.preview(opt_limit); 14 var preview = mirror.preview(opt_limit);
15 assertArrayEquals(expected, preview); 15 assertArrayEquals(expected, preview);
16 16
17 // Check that iterator has not changed after taking preview. 17 // Check that iterator has not changed after taking preview.
18 var values = []; 18 var values = [];
19 for (var i of iter) { 19 for (var i of iter) {
20 if (opt_limit && values.length >= opt_limit) break; 20 if (opt_limit && values.length >= opt_limit) break;
21 values.push(i); 21 values.push(i);
22 } 22 }
23 assertArrayEquals(expected, values); 23 assertArrayEquals(expected, values);
24 } 24 }
25 25
26 function testIteratorInternalProperties(iter, offset, kind, index, has_more) {
27 while (offset-- > 0) iter.next();
28
29 var mirror = debug.MakeMirror(iter);
30 assertTrue(mirror.isIterator());
31
32 var properties = mirror.internalProperties();
33 assertEquals(3, properties.length);
34 assertEquals("[[IteratorHasMore]]", properties[0].name());
35 assertEquals(has_more, properties[0].value().value());
36 assertEquals("[[IteratorIndex]]", properties[1].name());
37 assertEquals(index, properties[1].value().value());
38 assertEquals("[[IteratorKind]]", properties[2].name());
39 assertEquals(kind, properties[2].value().value());
40 }
41
26 var o1 = { foo: 1 }; 42 var o1 = { foo: 1 };
27 var o2 = { foo: 2 }; 43 var o2 = { foo: 2 };
28 44
29 var map = new Map(); 45 var map = new Map();
30 map.set(41, 42); 46 map.set(41, 42);
31 map.set(o1, o2); 47 map.set(o1, o2);
32 48
33 testIteratorMirror(map.keys(), 0, [41, o1]); 49 testIteratorMirror(map.keys(), 0, [41, o1]);
34 testIteratorMirror(map.values(), 0, [42, o2]); 50 testIteratorMirror(map.values(), 0, [42, o2]);
35 testIteratorMirror(map.entries(), 0, [[41, 42], [o1, o2]]); 51 testIteratorMirror(map.entries(), 0, [[41, 42], [o1, o2]]);
36 52
37 testIteratorMirror(map.keys(), 1, [o1]); 53 testIteratorMirror(map.keys(), 1, [o1]);
38 testIteratorMirror(map.values(), 1, [o2]); 54 testIteratorMirror(map.values(), 1, [o2]);
39 testIteratorMirror(map.entries(), 1, [[o1, o2]]); 55 testIteratorMirror(map.entries(), 1, [[o1, o2]]);
40 56
41 testIteratorMirror(map.keys(), 2, []); 57 testIteratorMirror(map.keys(), 2, []);
42 testIteratorMirror(map.values(), 2, []); 58 testIteratorMirror(map.values(), 2, []);
43 testIteratorMirror(map.entries(), 2, []); 59 testIteratorMirror(map.entries(), 2, []);
44 60
45 // Test with maximum limit. 61 // Test with maximum limit.
46 testIteratorMirror(map.keys(), 0, [41], 1); 62 testIteratorMirror(map.keys(), 0, [41], 1);
47 testIteratorMirror(map.values(), 0, [42], 1); 63 testIteratorMirror(map.values(), 0, [42], 1);
48 testIteratorMirror(map.entries(), 0, [[41, 42]], 1); 64 testIteratorMirror(map.entries(), 0, [[41, 42]], 1);
49 65
66 testIteratorInternalProperties(map.keys(), 0, "keys", 0, true);
67 testIteratorInternalProperties(map.values(), 1, "values", 1, true);
68 testIteratorInternalProperties(map.entries(), 2, "entries", 2, false);
69 testIteratorInternalProperties(map.keys(), 3, "keys", 2, false);
70
50 var set = new Set(); 71 var set = new Set();
51 set.add(41); 72 set.add(41);
52 set.add(42); 73 set.add(42);
53 set.add(o1); 74 set.add(o1);
54 set.add(o2); 75 set.add(o2);
55 76
56 testIteratorMirror(set.keys(), 0, [41, 42, o1, o2]); 77 testIteratorMirror(set.keys(), 0, [41, 42, o1, o2]);
57 testIteratorMirror(set.values(), 0, [41, 42, o1, o2]); 78 testIteratorMirror(set.values(), 0, [41, 42, o1, o2]);
58 testIteratorMirror(set.entries(), 0, [[41, 41], [42, 42], [o1, o1], [o2, o2]]); 79 testIteratorMirror(set.entries(), 0, [[41, 41], [42, 42], [o1, o1], [o2, o2]]);
59 80
60 testIteratorMirror(set.keys(), 1, [42, o1, o2]); 81 testIteratorMirror(set.keys(), 1, [42, o1, o2]);
61 testIteratorMirror(set.values(), 1, [42, o1, o2]); 82 testIteratorMirror(set.values(), 1, [42, o1, o2]);
62 testIteratorMirror(set.entries(), 1, [[42, 42], [o1, o1], [o2, o2]]); 83 testIteratorMirror(set.entries(), 1, [[42, 42], [o1, o1], [o2, o2]]);
63 84
64 testIteratorMirror(set.keys(), 3, [o2]); 85 testIteratorMirror(set.keys(), 3, [o2]);
65 testIteratorMirror(set.values(), 3, [o2]); 86 testIteratorMirror(set.values(), 3, [o2]);
66 testIteratorMirror(set.entries(), 3, [[o2, o2]]); 87 testIteratorMirror(set.entries(), 3, [[o2, o2]]);
67 88
68 testIteratorMirror(set.keys(), 5, []); 89 testIteratorMirror(set.keys(), 5, []);
69 testIteratorMirror(set.values(), 5, []); 90 testIteratorMirror(set.values(), 5, []);
70 testIteratorMirror(set.entries(), 5, []); 91 testIteratorMirror(set.entries(), 5, []);
71 92
72 // Test with maximum limit. 93 // Test with maximum limit.
73 testIteratorMirror(set.keys(), 1, [42, o1], 2); 94 testIteratorMirror(set.keys(), 1, [42, o1], 2);
74 testIteratorMirror(set.values(), 1, [42, o1], 2); 95 testIteratorMirror(set.values(), 1, [42, o1], 2);
75 testIteratorMirror(set.entries(), 1, [[42, 42], [o1, o1]], 2); 96 testIteratorMirror(set.entries(), 1, [[42, 42], [o1, o1]], 2);
97
98 testIteratorInternalProperties(set.keys(), 0, "values", 0, true);
99 testIteratorInternalProperties(set.values(), 1, "values", 1, true);
100 testIteratorInternalProperties(set.entries(), 2, "entries", 2, true);
101 testIteratorInternalProperties(set.keys(), 3, "values", 3, true);
102 testIteratorInternalProperties(set.values(), 4, "values", 4, false);
103 testIteratorInternalProperties(set.entries(), 5, "entries", 4, false);
OLDNEW
« no previous file with comments | « src/runtime/runtime-collections.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698