Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 710273002: Expose internal properties of map/set iterators via mirrors. (Closed)

Created:
6 years, 1 month ago by aandrey
Modified:
6 years, 1 month ago
Reviewers:
vsevik, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M src/mirror-debugger.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-collections.cc View 1 2 chunks +32 lines, -0 lines 0 comments Download
M test/mjsunit/es6/mirror-iterators.js View 1 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
aandrey
6 years, 1 month ago (2014-11-11 08:38:10 UTC) #1
aandrey
ping?
6 years, 1 month ago (2014-11-14 08:27:24 UTC) #2
Yang
On 2014/11/14 08:27:24, aandrey wrote: > ping? lgtm. sorry about the delay.
6 years, 1 month ago (2014-11-17 10:40:57 UTC) #3
aandrey
Committed patchset #2 (id:20001) manually as d5f5d38f73f43eba9658d91ffbe511af8c340d78 (presubmit successful).
6 years, 1 month ago (2014-11-17 12:20:40 UTC) #4
aandrey
6 years, 1 month ago (2014-11-17 12:48:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
685bc04a01853072bbdd04d1a4fc7e0a360bbd4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698