Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 710253003: Add some necessary configuration_policy gyp conditions (Closed)

Created:
6 years, 1 month ago by eirik
Modified:
6 years, 1 month ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, ygorshenin1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add some necessary configuration_policy gyp conditions These targets are defined inside a condition, so their usage must clearly be inside the same condition. BUG= Committed: https://crrev.com/bf865e0424ac895a0937a07c0218c424713fdb13 Cr-Commit-Position: refs/heads/master@{#303807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M components/ownership.gypi View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eirik
6 years, 1 month ago (2014-11-11 13:20:31 UTC) #2
Cait (Slow)
[cc ygorshenin@chromium.org, owner of the ownership component] LGTM pending green trybots FWIW, src/chrome/chromeos.gyp and src/chrome/chrome_browser_chromeos.gypi ...
6 years, 1 month ago (2014-11-11 15:56:56 UTC) #3
eirik
On 2014/11/11 15:56:56, Cait Phillips wrote: > [cc mailto:ygorshenin@chromium.org, owner of the ownership component] > ...
6 years, 1 month ago (2014-11-12 08:18:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710253003/1
6 years, 1 month ago (2014-11-12 08:19:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 09:09:24 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 09:10:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf865e0424ac895a0937a07c0218c424713fdb13
Cr-Commit-Position: refs/heads/master@{#303807}

Powered by Google App Engine
This is Rietveld 408576698