Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 710203006: Reland: Remove aura and make a pure mojo::View version of FocusController. (Closed)

Created:
6 years, 1 month ago by Elliot Glaysher
Modified:
6 years, 1 month ago
Reviewers:
sky, eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Reland: Remove aura and make a pure mojo::View version of FocusController. [Changes: Remove additional deps which Linux/Windows was fine with, but which broke android because it implied an aura dependency. window_manager should now be properly deauraed.] This patch is only half done, however the main driver (removing aura) is needed by other teams for them to make progress. Input handling is regressed in this patch; while FocusController is rebuilt to the point where it should theoretically work, all of the details about ui::EventTargeter don't work correctly. There is an empty subclass ViewTargeter which will need to be filled out before Thankfully, this should only regress people who are using the wm_flow demo, and this should unblock the android guys who don't have aura support on their platform. BUG=431047 TBR=eseidel@chromium.org, sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/28b50b9614ca0d12f072d57389049ec38ac734bb

Patch Set 1 #

Patch Set 2 : Remove the offending lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1165 lines, -473 lines) Patch
M examples/window_manager/window_manager.cc View 5 chunks +14 lines, -67 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.h View 3 chunks +1 line, -8 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 3 chunks +1 line, -4 lines 0 comments Download
M examples/wm_flow/wm/wm.cc View 3 chunks +5 lines, -70 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/view_manager/view_tracker.h View 1 chunk +47 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/view_manager/view_tracker.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 1 5 chunks +12 lines, -10 lines 0 comments Download
A mojo/services/window_manager/basic_focus_rules.h View 1 chunk +48 lines, -0 lines 0 comments Download
A mojo/services/window_manager/basic_focus_rules.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A mojo/services/window_manager/focus_controller.h View 1 chunk +100 lines, -0 lines 0 comments Download
A mojo/services/window_manager/focus_controller.cc View 1 chunk +303 lines, -0 lines 0 comments Download
A mojo/services/window_manager/focus_controller_observer.h View 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/services/window_manager/focus_rules.h View 1 chunk +62 lines, -0 lines 0 comments Download
M mojo/services/window_manager/native_viewport_event_dispatcher_impl.h View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/services/window_manager/native_viewport_event_dispatcher_impl.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
A mojo/services/window_manager/view_event_dispatcher.h View 1 chunk +46 lines, -0 lines 0 comments Download
A mojo/services/window_manager/view_event_dispatcher.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A mojo/services/window_manager/view_target.h View 1 chunk +64 lines, -0 lines 0 comments Download
A mojo/services/window_manager/view_target.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A mojo/services/window_manager/view_targeter.h View 1 chunk +23 lines, -0 lines 0 comments Download
A + mojo/services/window_manager/view_targeter.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 8 chunks +38 lines, -56 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 12 chunks +80 lines, -139 lines 0 comments Download
M sky/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M sky/tools/debugger/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/tools/debugger/debugger.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/debugger/debugger.cc View 2 chunks +4 lines, -2 lines 0 comments Download
D sky/tools/debugger/focus_rules.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/tools/debugger/focus_rules.cc View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Elliot Glaysher
6 years, 1 month ago (2014-11-11 01:06:52 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
28b50b9614ca0d12f072d57389049ec38ac734bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698