Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 710193003: Reduce the number of times we build a host copy of python. (Closed)

Created:
6 years, 1 month ago by Sam Clegg
Modified:
6 years, 1 month ago
Reviewers:
bradn, binji
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Visibility:
Public.

Description

Reduce the number of times we build a host copy of python. python and python-static packages now both depend on the same copy of host-python, which mean we only need to build it once. Also, update documentation in README about python build dependencies to include information on Ununtu/Trusty. R=bradnelson@google.com Committed: https://chromium.googlesource.com/external/naclports/+/5cf1be27f5409651ecb4773fba3265207f467985

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -728 lines) Patch
M README.rst View 1 chunk +12 lines, -3 lines 2 comments Download
M build_tools/README.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M build_tools/common.sh View 1 chunk +2 lines, -1 line 0 comments Download
M build_tools/partition4.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build_tools/partition5.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ports/font-util/build.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M ports/gforth/build.sh View 1 chunk +2 lines, -2 lines 0 comments Download
A + ports/python-host/build.sh View 2 chunks +2 lines, -5 lines 0 comments Download
A + ports/python-host/nacl.patch View 2 chunks +3 lines, -3 lines 0 comments Download
A + ports/python-host/pkg_info View 0 chunks +-1 lines, --1 lines 0 comments Download
M ports/python-static/build.sh View 2 chunks +2 lines, -2 lines 0 comments Download
M ports/python-static/nacl.patch View 2 chunks +2 lines, -2 lines 0 comments Download
M ports/python-static/pkg_info View 1 chunk +1 line, -1 line 0 comments Download
M ports/python/build.sh View 2 chunks +2 lines, -23 lines 0 comments Download
M ports/python/nacl.patch View 2 chunks +3 lines, -3 lines 0 comments Download
M ports/python/pkg_info View 1 chunk +1 line, -1 line 0 comments Download
D ports/python_modules/python-host/build.sh View 1 chunk +0 lines, -26 lines 0 comments Download
D ports/python_modules/python-host/nacl.patch View 1 chunk +0 lines, -643 lines 0 comments Download
D ports/python_modules/python-host/pkg_info View 1 chunk +0 lines, -6 lines 0 comments Download
M ports/ruby/build.sh View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam Clegg
6 years, 1 month ago (2014-11-10 20:11:24 UTC) #2
Sam Clegg
+binji as brad is OOO
6 years, 1 month ago (2014-11-10 22:14:33 UTC) #4
bradn
I'm here, hiding... LGTM
6 years, 1 month ago (2014-11-10 22:18:39 UTC) #6
binji
couple things I noticed. Didn't do a full review https://codereview.chromium.org/710193003/diff/40001/README.rst File README.rst (right): https://codereview.chromium.org/710193003/diff/40001/README.rst#newcode72 README.rst:72: ...
6 years, 1 month ago (2014-11-10 22:21:30 UTC) #7
Sam Clegg
6 years, 1 month ago (2014-11-10 22:46:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
5cf1be27f5409651ecb4773fba3265207f467985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698