Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 710173004: Implement seekable() according to the MediaSource specification (Closed)

Created:
6 years, 1 month ago by Henrik Steen
Modified:
6 years, 1 month ago
Reviewers:
philipj_slow, fs
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement seekable() according to the MediaSource specification BUG=432051 R=philipj@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185191

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix some small review nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
A LayoutTests/http/tests/media/media-source/mediasource-seekable.html View 1 1 chunk +70 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/media/media-source/mediasource-seekable-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-util.js View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaSource.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediasource/MediaSource.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Henrik Steen
6 years, 1 month ago (2014-11-11 09:22:01 UTC) #2
philipj_slow
LGTM % nits https://codereview.chromium.org/710173004/diff/1/LayoutTests/http/tests/media/media-source/mediasource-seekable.html File LayoutTests/http/tests/media/media-source/mediasource-seekable.html (right): https://codereview.chromium.org/710173004/diff/1/LayoutTests/http/tests/media/media-source/mediasource-seekable.html#newcode15 LayoutTests/http/tests/media/media-source/mediasource-seekable.html:15: mediaElement.pause(); Why is this needed? I ...
6 years, 1 month ago (2014-11-11 10:09:02 UTC) #3
Henrik Steen
https://codereview.chromium.org/710173004/diff/1/Source/modules/mediasource/MediaSource.cpp File Source/modules/mediasource/MediaSource.cpp (right): https://codereview.chromium.org/710173004/diff/1/Source/modules/mediasource/MediaSource.cpp#newcode378 Source/modules/mediasource/MediaSource.cpp:378: if (buffered->length() == 0) On 2014/11/11 10:09:02, philipj wrote: ...
6 years, 1 month ago (2014-11-11 10:42:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710173004/20001
6 years, 1 month ago (2014-11-12 07:03:37 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 08:21:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185191

Powered by Google App Engine
This is Rietveld 408576698