Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 710133002: Make Sky's test_perf actually test performance (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make Sky's test_perf actually test performance This CL teaches test_perf how to walk the benchmarks directory to find the benchmarks and how to actually run them. We're still not uploading results to the server yet, however. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f926cc21b522e735d684983cc10e79f839f8950f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -12 lines) Patch
A sky/tools/skypy/find_tests.py View 1 chunk +20 lines, -0 lines 0 comments Download
M sky/tools/test_perf View 4 chunks +34 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-10 17:36:26 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-11-10 18:29:37 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-11-10 18:30:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f926cc21b522e735d684983cc10e79f839f8950f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698