cloud_print/virtual_driver/win/install/setup.cc - Issue 71013004: Base: Remove Receive() from ScopedHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/virtual_driver/win/install/setup.cc

Issue 71013004: Base: Remove Receive() from ScopedHandle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add constructor Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/virtual_driver/win/install/setup.cc

diff --git a/cloud_print/virtual_driver/win/install/setup.cc b/cloud_print/virtual_driver/win/install/setup.cc

index 6e0df245a73e9f446492d375ffe188bbbdf630ce..e20339235e6b1bb3f0a7004868d1ccadd39e9070 100644

--- a/cloud_print/virtual_driver/win/install/setup.cc

+++ b/cloud_print/virtual_driver/win/install/setup.cc

@@ -140,7 +140,8 @@ HRESULT RegisterPortMonitor(bool install, const base::FilePath& install_path) {

options.wait = true;

base::win::ScopedHandle regsvr32_handle;

- if (!base::LaunchProcess(command_line, options, regsvr32_handle.Receive())) {

+ if (!base::LaunchProcess(command_line.GetCommandLineString(), options,

+ &regsvr32_handle)) {

LOG(ERROR) << "Unable to launch regsvr32.exe.";

return HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED);

}