Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome_frame/test_utils.cc

Issue 71013004: Base: Remove Receive() from ScopedHandle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add constructor Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test_utils.cc
diff --git a/chrome_frame/test_utils.cc b/chrome_frame/test_utils.cc
index ef780468f44d4e7d156c08f7a310442e1ef0e3a1..cd8b41e88cd06d03cc29fc76c3f974a609657dd7 100644
--- a/chrome_frame/test_utils.cc
+++ b/chrome_frame/test_utils.cc
@@ -88,7 +88,7 @@ void ScopedChromeFrameRegistrar::DoRegistration(
int entrypoint_index = 0;
base::LaunchOptions launch_options;
- base::ProcessHandle process_handle = INVALID_HANDLE_VALUE;
+ base::win::ScopedHandle process_handle;
int exit_code = -1;
if (registration_type == PER_USER)
@@ -111,13 +111,13 @@ void ScopedChromeFrameRegistrar::DoRegistration(
<< "Failed to register or unregister DLL with command: "
<< registration_command;
} else {
- base::win::ScopedHandle rundll32(process_handle);
+ base::win::ScopedHandle rundll32(process_handle.Get());
if (!base::WaitForExitCodeWithTimeout(
- process_handle, &exit_code,
+ process_handle.Get(), &exit_code,
base::TimeDelta::FromMilliseconds(kDllRegistrationTimeoutMs))) {
LOG(ERROR) << "Timeout waiting to register or unregister DLL with "
"command: " << registration_command;
- base::KillProcess(process_handle, 0, false);
+ base::KillProcess(process_handle.Get(), 0, false);
NOTREACHED() << "Aborting test due to registration failure.";
}
}

Powered by Google App Engine
This is Rietveld 408576698