Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 71013004: Base: Remove Receive() from ScopedHandle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add constructor Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/nacl_process_host.cc
diff --git a/chrome/browser/nacl_host/nacl_process_host.cc b/chrome/browser/nacl_host/nacl_process_host.cc
index 530ebbb50318b7ab873e46560581e670801946ad..7059460a7824704eb68b458fddd3a3cf9c8b474c 100644
--- a/chrome/browser/nacl_host/nacl_process_host.cc
+++ b/chrome/browser/nacl_host/nacl_process_host.cc
@@ -979,7 +979,7 @@ bool NaClProcessHost::AttachDebugExceptionHandler(const std::string& info,
debug_exception_handler_requested_ = true;
base::ProcessId nacl_pid = base::GetProcId(process_->GetData().handle);
- base::win::ScopedHandle process_handle;
+ base::ProcessHandle temp_handle;
// We cannot use process_->GetData().handle because it does not have
// the necessary access rights. We open the new handle here rather
// than in the NaCl broker process in case the NaCl loader process
@@ -998,10 +998,12 @@ bool NaClProcessHost::AttachDebugExceptionHandler(const std::string& info,
base::kProcessAccessVMWrite |
base::kProcessAccessDuplicateHandle |
base::kProcessAccessWaitForTermination,
- process_handle.Receive())) {
+ &temp_handle)) {
LOG(ERROR) << "Failed to get process handle";
return false;
}
+ base::win::ScopedHandle process_handle;
+ process_handle.Set(temp_handle);
attach_debug_exception_handler_reply_msg_.reset(reply_msg);
// If the NaCl loader is 64-bit, the process running its debug

Powered by Google App Engine
This is Rietveld 408576698